Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy provider logic for DAG wrapper functions #1398

Closed
1 task
AetherUnbound opened this issue Oct 25, 2022 · 0 comments · Fixed by WordPress/openverse-catalog#849
Closed
1 task
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🐍 tech: python Involves Python

Comments

@AetherUnbound
Copy link
Collaborator

Description

While working on the provider refactors, we needed to support both the ingestion classes and the module-based legacy providers. Once the provider refactors are complete, we can remove the logic we had around handling these legacy provider scripts:

https://github.com/WordPress/openverse-catalog/blob/b4ef93ce5f825e4ae0e3ba3814340ec42ade7fa2/openverse_catalog/dags/providers/factory_utils.py#L63-L66

We can also modify the ProviderWorkflow class to make more assumptions about the workflow based on the ingestion class alone. We should now be able to dynamically determine the provider name and media types rather than having to explicitly define them (for most cases):

https://github.com/WordPress/openverse-catalog/blob/8c26510d7479fbac23803361b4be08c12e43f045/openverse_catalog/dags/providers/provider_workflows.py#L147-L151

We'll need to complete all refactors in order to remove these legacy shims.

Additional context

For more context on the latter point, see this discussion: WordPress/openverse-catalog#790 (comment)

Implementation

  • 🙋 I would be interested in implementing this feature.
@AetherUnbound AetherUnbound added ⛔ status: blocked Blocked & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 🐍 tech: python Involves Python 💻 aspect: code Concerns the software code in the repository 🟧 priority: high Stalls work on the project or its dependents labels Oct 25, 2022
@stacimc stacimc self-assigned this Oct 27, 2022
@krysal krysal removed the ⛔ status: blocked Blocked & therefore, not ready for work label Oct 30, 2022
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🐍 tech: python Involves Python
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants