Remove legacy provider logic for DAG wrapper functions #1398
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟧 priority: high
Stalls work on the project or its dependents
🐍 tech: python
Involves Python
Description
While working on the provider refactors, we needed to support both the ingestion classes and the module-based legacy providers. Once the provider refactors are complete, we can remove the logic we had around handling these legacy provider scripts:
https://github.com/WordPress/openverse-catalog/blob/b4ef93ce5f825e4ae0e3ba3814340ec42ade7fa2/openverse_catalog/dags/providers/factory_utils.py#L63-L66
We can also modify the
ProviderWorkflow
class to make more assumptions about the workflow based on the ingestion class alone. We should now be able to dynamically determine the provider name and media types rather than having to explicitly define them (for most cases):https://github.com/WordPress/openverse-catalog/blob/8c26510d7479fbac23803361b4be08c12e43f045/openverse_catalog/dags/providers/provider_workflows.py#L147-L151
We'll need to complete all refactors in order to remove these legacy shims.
Additional context
For more context on the latter point, see this discussion: WordPress/openverse-catalog#790 (comment)
Implementation
The text was updated successfully, but these errors were encountered: