Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nginx configuration logs structured (JSON) and unstructured output for every event #2245

Closed
sarayourfriend opened this issue May 31, 2023 · 1 comment
Closed

Nginx configuration logs structured (JSON) and unstructured output for every event #2245

sarayourfriend opened this issue May 31, 2023 · 1 comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

Description

The API's Nginx configuration logs both structured and unstructured log lines. This means every log line is effectively duplicated, costing us double and making querying slightly more complex.

Fix

Unless we read the Nginx logs by hand (i.e., we aren't querying them via Logs Insights), then we can do away with the unstructured logs and only logs the JSON logs.
@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: api Related to the Django API labels May 31, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog May 31, 2023
@sarayourfriend
Copy link
Collaborator Author

Olga solved this in #3163

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sarayourfriend