Skip to content

"Release app" workflow concurrency configuration does not work as expected #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarayourfriend opened this issue Jun 13, 2023 · 0 comments
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon

Comments

@sarayourfriend
Copy link
Collaborator

Description

The "Release app" workflow's concurrency configuration uses the app input. However, inputs is not available in that particular block.

Reproduction

  1. Run the "Release app" workflow for multiple different apps concurrently and they will block on each other.

See this example of a run that was cancelled due to another run for a different app coming after it and taking priority.

Fix

The fix is to move the concurrency block to a place where inputs is available: https://github.com/orgs/community/discussions/35341

This will still be necessary if we implement #2264

@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Jun 13, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant