Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup tag display with long lists of tags #2589

Closed
Tracked by #2775
zackkrida opened this issue Jul 7, 2023 · 8 comments · Fixed by #3808
Closed
Tracked by #2775

Cleanup tag display with long lists of tags #2589

zackkrida opened this issue Jul 7, 2023 · 8 comments · Fixed by #3808
Assignees
Labels
🖼️ aspect: design Concerns related to design design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

zackkrida commented Jul 7, 2023

Problem

Some images, particularly from platforms like Flickr, have many many tags. The display of these tags is distracting, particularly on mobile:

An example: https://openverse.org/image/7e138814-e774-45fb-91ee-7b728c174616?q=Titmouse

Single result page screenshot

Description

Truncate the tags list to a fixed number of rows. We can do this hackily in CSS with height or some other method. Use additional styling to indicate the list is expansible.

Alternatives

Additional context

@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🖼️ aspect: design Concerns related to design 🧱 stack: frontend Related to the Nuxt frontend labels Jul 7, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Jul 7, 2023
@openverse-bot
Copy link
Collaborator

Subscribe to Label Action

cc @WordPress/gutenberg-design, @WordPress/openverse

This issue or pull request has been labeled: "🖼️ aspect: design"

Thus the following users have been cc'd because of the following labels:

  • WordPress/gutenberg-design: 🖼️ aspect: design
  • WordPress/openverse: 🖼️ aspect: design

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@fcoveram
Copy link
Contributor

fcoveram commented Jul 11, 2023

Great finding. Thanks for the ticket ✨

Here is an idea that can be implemented in line with #410, and that can be found in #2113's design file

Two mokcups of image details page. Tag area collapsed in the left, tag area expanded in the right

Since XS breakpoint has the smaller area, I envision three visible rows of tags. In XL and 2XL could be the same, but I wonder how that dynamic behavior can be applied consistently across all breakpoints.

What do you think @obulat and @dhruvkb?

@fcoveram fcoveram self-assigned this Jul 11, 2023
@fcoveram fcoveram added the design: in discussion Issue has a design that needs feedback label Jul 11, 2023
@fcoveram fcoveram moved this from 📋 Backlog to 🏗 In progress in Openverse Backlog Jul 24, 2023
@AetherUnbound
Copy link
Collaborator

This is great! As I look at those screenshots you shared, it can be a little tough initially to tell that the "Show all tags" element is something that can be interacted with. Is that consistent with the way similar elements are displayed in the rest of our app? Is there a way to make it seem a bit more like a button/interactive element? Please disregard if this fits other paradigms I'm unaware of 😄

@zackkrida
Copy link
Member Author

It looks very nice! Development-wise anything we do for this issue might be deceptively challenging. We'll have to make sure it's accessible and crucially decide what type of component we think this is. Perhaps an "accordian" is the closest-related pattern.

@fcoveram
Copy link
Contributor

it can be a little tough initially to tell that the "Show all tags" element is something that can be interacted with. Is that consistent with the way similar elements are displayed in the rest of our app? Is there a way to make it seem a bit more like a button/interactive element?

The button size is consistent with other buttons toggling similar actions. I tried a different style that might work well on small breakpoints, but it becomes too wide on md and beyond. Here is an example

Image details page on mobile and desktop where tag area is highlighted

First release

As writing this comment, I think we can go with full-width for xs / sm and width auto for md and beyond.

@krysal
Copy link
Member

krysal commented Aug 17, 2023

I like more the version of just bold text plus the caret. The button calls more interaction but it doesn't seem so necessary for this case.

@fcoveram
Copy link
Contributor

I asked for feedback on the accessibility channel and received the following response from nickthegeek:

This is a good design pattern as long as it’s implemented accessibly. Here are a few things to remember:

  • Use a button for the toggle
  • Use aria-controls and aria-expanded on the toggle
  • Use aria-hidden on the hidden section
  • I’d personally use the aria-hidden to show/hide. ie [aria-hidden="true"] { display: none; }. It’s not an a11y requirement but I find devs get the toggles right when they visibly see then doing their thing
  • When the content is hidden use either display or visibility to hide the content. These do not animate on transition but you can use visibility then opacity, height, etc which do animate. The reason display and visibility are important is if a user is using a keyboard to navigate they could still access all of the tags but not see them.

@fcoveram
Copy link
Contributor

I think we can go with the first idea for this release and see how people interact with it.

Two mockups of image details page. Tag area collapsed in the left, tag area expanded in the right

The mockups are in #410's designs in the "Use cases" section.

@fcoveram fcoveram added design: ready Issue with a mockup ready for implementation and removed design: in discussion Issue has a design that needs feedback labels Aug 18, 2023
@obulat obulat moved this from 🏗 In progress to 📅 To do in Openverse Backlog Aug 18, 2023
@krysal krysal moved this from 📅 To do to 📋 Backlog in Openverse Backlog Aug 31, 2023
@obulat obulat moved this from 📋 Backlog to 📅 To do in Openverse Backlog Sep 6, 2023
@sarayourfriend sarayourfriend removed their assignment Oct 23, 2023
@sarayourfriend sarayourfriend self-assigned this Nov 6, 2023
@sarayourfriend sarayourfriend moved this from 📅 To do to 🏗 In progress in Openverse Backlog Nov 13, 2023
@sarayourfriend sarayourfriend moved this from 🏗 In progress to 📅 To do in Openverse Backlog Nov 13, 2023
@sarayourfriend sarayourfriend removed their assignment Dec 4, 2023
@krysal krysal moved this from 📅 To Do to 📋 Backlog in Openverse Backlog Jan 15, 2024
@AetherUnbound AetherUnbound moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Jan 26, 2024
@obulat obulat self-assigned this Feb 19, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Feb 19, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖼️ aspect: design Concerns related to design design: ready Issue with a mockup ready for implementation ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants