Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NYPL DAG to use the API v2 #2747

Closed
krysal opened this issue Aug 1, 2023 · 0 comments · Fixed by #3774
Closed

Change NYPL DAG to use the API v2 #2747

krysal opened this issue Aug 1, 2023 · 0 comments · Fixed by #3774
Assignees
@AetherUnbound
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow

Comments

@krysal
Copy link
Member

krysal commented Aug 1, 2023

Description

The v1 API for NYPL is no longer available. The DAG needs to be updated to use the v2, until that happens it remains disabled and we don't get the lastest images.

Reproduction

  1. Go to http://api.repo.nypl.org/api/v1/items/search/?q=CC_0&field=use_rtxt_s&page=1&per_page=500
  2. See error message.
@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🔧 tech: airflow Involves Apache Airflow 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Aug 1, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Aug 1, 2023
@krysal krysal changed the title <Replace this with actual title> Change NYPL DAG to use the API v2 Aug 1, 2023
@obulat obulat moved this from 📋 Backlog to 📅 To do in Openverse Backlog Sep 26, 2023
@obulat obulat self-assigned this Sep 26, 2023
@AetherUnbound AetherUnbound moved this from 📅 To do to 📋 Backlog in Openverse Backlog Oct 4, 2023
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Jan 29, 2024
@AetherUnbound AetherUnbound mentioned this issue Feb 9, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Feb 9, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AetherUnbound AetherUnbound

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update NYPL DAG to use API v2 WordPress/openverse
3 participants
@krysal @AetherUnbound @obulat