Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ruff (and other pre-commit hooks) #3212

Closed
dhruvkb opened this issue Oct 17, 2023 · 3 comments
Closed

Upgrade Ruff (and other pre-commit hooks) #3212

dhruvkb opened this issue Oct 17, 2023 · 3 comments
Assignees
@sarayourfriend
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Oct 17, 2023

Problem

Ruff recently released v0.1.0. This reminds me that we do not currently have a way to automatically update our pre-commit hooks like we have Dependabot for Python and Node.js packages, and Renovate for GitHub Actions.

Description

Update our pre-commit hooks. A potential further improvement would be to find, recommend and/or implement some action that can automatically update the hooks periodically (like Dependabot does at the start of each month).

Additional context

pre-commit, our linting and hooks framework of choice, has built-in support for updating hooks using the autoupdate subcommand.
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Oct 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Oct 17, 2023
@agnes-sharan
Copy link

Hi, is this open for contribution?

@dhruvkb
Copy link
Member Author

dhruvkb commented Oct 19, 2023

Yes @agnes-sharan it is open. I'll assign it to you.

@sarayourfriend
Copy link
Collaborator

This was resolved by #3312.

@sarayourfriend sarayourfriend moved this from 📋 Backlog to ✅ Done in Openverse Backlog Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarayourfriend sarayourfriend

Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhruvkb @sarayourfriend @agnes-sharan