Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dangling migration in API #3310

Closed
sarayourfriend opened this issue Nov 2, 2023 · 4 comments · Fixed by #3329
Closed

Dangling migration in API #3310

sarayourfriend opened this issue Nov 2, 2023 · 4 comments · Fixed by #3329
Assignees
@dhruvkb @sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Nov 2, 2023 •
edited
Loading

Description

just api/dj makemigrations on main results in api/api/migrations/0055_alter_matureimage_media_obj.py.

Additional context

Why didn't the check_migrations check catch this? The check is required 🤔 cc @dhruvkb in case you have any CI/CD related ideas. Theoretically it should be failing on all PRs that make changes to the API...
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Nov 2, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Nov 2, 2023
@sarayourfriend sarayourfriend self-assigned this Nov 3, 2023
@sarayourfriend sarayourfriend moved this from 📋 Backlog to 🏗 In progress in Openverse Backlog Nov 3, 2023
@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP and removed 🟧 priority: high Stalls work on the project or its dependents labels Nov 3, 2023
@sarayourfriend sarayourfriend mentioned this issue Nov 3, 2023
Merged
5 tasks
@dhruvkb
Copy link
Member

dhruvkb commented Nov 3, 2023

Added a to-do for myself to investigate why the checkmigrations job did not catch this.

@sarayourfriend
Copy link
Collaborator Author

@dhruvkb Would you prefer to open a separate issue or to leave this one open after #3311 is merged?

@dhruvkb
Copy link
Member

dhruvkb commented Nov 6, 2023 •
edited
Loading

We can keep this open, I don't think the new one will have anything more to add that what's in the description of this issue.

@dhruvkb dhruvkb self-assigned this Nov 6, 2023
@AetherUnbound AetherUnbound added 🟧 priority: high Stalls work on the project or its dependents and removed 🟥 priority: critical Must be addressed ASAP labels Nov 6, 2023
@AetherUnbound
Copy link
Collaborator

Bumping this down to "high" priority since the original issue has been addressed.

@dhruvkb dhruvkb mentioned this issue Nov 8, 2023
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Openverse Backlog Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove --merge and --noinput flags in Django migration check WordPress/openverse
3 participants
@AetherUnbound @dhruvkb @sarayourfriend