Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Related endpoint error is still sent to Sentry #4006

Closed
obulat opened this issue Apr 2, 2024 · 1 comment · Fixed by #4009
Closed

Related endpoint error is still sent to Sentry #4006

obulat opened this issue Apr 2, 2024 · 1 comment · Fixed by #4009
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Apr 2, 2024

Description

#3850 stopped sending the network errors to Sentry. However, the following line was accidentally left and this is causing the /related endpoint to send network errors to both Sentry and to Plausible:

openverse/frontend/src/stores/media/related-media.ts

Line 71 in a51ac8d

this.$nuxt.$sentry.captureException(error, { extra: { errorData } })

Sentry error link

https://openverse.sentry.io/share/issue/acf65e34d4d84d9887bc0bc887743ac0/

Additional context

To fix this issue, the line in the description should be deleted.
@obulat obulat added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Apr 2, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Apr 2, 2024
jeevikasirwani added a commit to jeevikasirwani/openverse that referenced this issue Apr 2, 2024
@jeevikasirwani
fix:Related endpoint error is still sent to Sentry WordPress#4006
5be7bc9
@jeevikasirwani jeevikasirwani mentioned this issue Apr 2, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📋 Backlog to 🏗 In Progress in Openverse Backlog Apr 2, 2024
sarayourfriend pushed a commit that referenced this issue Apr 8, 2024
@jeevikasirwani @obulat
Related endpoint error is still sent to Sentry (#4009)
3cf0fdd 
* fix:Related endpoint error is still sent to Sentry #4006

* Update frontend/src/stores/media/related-media.ts

Co-authored-by: Olga Bulat <obulat@gmail.com>

---------

Co-authored-by: Olga Bulat <obulat@gmail.com>
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Apr 8, 2024
@sentry-io Sentry.io
Copy link

sentry-io bot commented Apr 12, 2024

Sentry Issue: OPENVERSE-FRONTEND-1H9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Related endpoint error is still sent to Sentry jeevikasirwani/openverse
1 participant
@obulat