-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode feature introduction flow #4157
Comments
Subscribe to Label Actioncc @WordPress/gutenberg-design, @WordPress/openverse
This issue or pull request has been labeled: "🖼️ aspect: design"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Beautiful work as always. As I think we discussed in a chat, there are a few ways to do this:
Of those, 1 appeals to me because it's very simple. I also have a slight aversion to welcome modals that get in my way, though I like that you've positioned this as a "What's new" modal: ooh new goodies! Whether it's a notice or a modal, I'm happy to defer to you and everyone else, both can work fine. The notice gets less in the way, though, so the main question to answer is: is dark mode a substantial enough feature to warrant the modal instead of the notice? My instinct: probably. |
I've added |
I like the idea of the modal and how you've presented it here! I worry though about how we might be able to actually manage showing the modal only once on an implementation level. Currently I feel like I have to dismiss our existing analytics banner quite frequently when using the search; it would be unpleasant to have to dismiss the modal multiple times across different devices or even multiple times on the same device depending on how we save session state information. I do think rolling dark mode out with system as default would be a good alternative to this though! It doesn't solve the more general feature introduction flow though. |
I also think this looks fantastic, but think it ultimately might be too intrusive. The main use case I'm concerned with is first-time Openverse users and the added barrier of making a search. The majority of our traffic is on desktop and our homepage is fixed-height, so the control will immediately be visible to users. I do think that defaulting to system would work well to fix this issue. Any user who is sufficiently tech-savvy enough to enable dark mode on their system or browser will 1. probably appreciate Openverse's dark mode, and 2. if they do not like it, should be able to find the footer control to disable it. |
Agreed on the intrusiveness of it. Is there an option where we somehow highlight the toggle itself, maybe with a tooltip indicating the feature is new? If we do anything for this, I'd like also to have a timeline defined for when we would deprecate the feature. It should not live indefinitely.
My request for this is a bit off-topic, but @AetherUnbound can you create an issue for this and describe how to reproduce it? Doesn't sound right you're needing to re-close these on a regular basis; but I can reproduce it for the analytics banner for sure. Might be an SSR issue? We shouldn't discuss it here, but it definitely needs an issue to investigate as a bug. |
I have another less intrusive idea I can go back to, and also try something as minimal as possible. First-time users is definitely a concern, but I also think it's good to consider a system for introducing features no matter the expertise level. This tech-savvy feature is simple in terms of steps required, but the additional search views involve more screens and we didn't consider an introduction stage when outlining the project. |
Coming back here after a few days to share a new version. Before diving into details, here is a recording of a prototype. CleanShot.2024-05-06.at.13.13.25.mp4The idea main idea behind this proposal is showing a whats-new message in the home page while stand out the theme switcher until the user clicks on it. The homepage's banner is a link that takes you to the latest release page on Github where more details are added. The glowing button meets the WCAG requirements, and for the motion reduction settings, we can set the border in dark (text-primary color) and change its width from 1.5px to 3px without the transition effect. We can reuse this pattern in upcoming features that impact the UX more significantly. In cases where the feature is a set of views or flows that are not afford through a single UI's component, we can safely skip the glowing button and rely on the release page. There we can include recordings and mockups describing what changed and how users can use it. I'm thinking this scenario specifically for the #410 project where we missed this introductory stage. For a more real interaction, you can check this prototype. |
This is... so cool. I love it, I think it's an excellent approach for showcasing new features without being too intrusive. Amazing!! 🤩 |
The dark notification message intends to be intrusive. For that reason is that I suggested not overusing it in other scenarios and instead finding more in-context manners of announcing changes. However, that screen @sarayourfriend definitely looks overloaded. I was thinking of adding the announcement banner on both desktop and mobile. But I agree there is room for improvement in having a cleaner layout. |
Looking at the screenshot again, I wonder if for mobile we could put the language and colour scheme selector on the same row, so that each are only half the page? Some longer language names might not fit, but very few are that long. Because the screen is so much smaller on mobile, with the highlight effect, the colour scheme button would be pretty noticeable (it isn't far from the main content so that you could miss it, like it is on desktop). |
Yes. The change requested in #4155 includes the footer in this way. Here is a screenshot from the dark mode file where footer variants are added. |
I created the mockups for the smallest breakpoint, and here is the outcome. The mockups has the following changes:
While revisiting the current homepage, I noticed other minor text styles we could correct in the PR. In addition to that, I also think we could include The assets are ready in the Mockups page. |
Replacing the |
@zackkrida Does this need an implementation plan ticket or will it be a one-off issue? It looks like there could be individual components related to this, but I'm not sure if they're separate PRs, necessarily. We probably need to fix the problem @AetherUnbound identified in this thread, which I reproduced in this comment as well: #4157 (comment) My concern is whether whatever we use to indicate this visitor already knows about this feature would cause the experience to differ? Although, I'm wondering if this is potentially related to the change we made in Cloudflare regarding session cookies and cache bypass 🤔 |
@sarayourfriend I believe the issue @AetherUnbound identified is updated as of the session cookies and cache bypass changes we made. As of this issue: #4308, user color mode selection will be stored in the existing UI cookie which is already being used to bypass the page cache. I think we should dismiss this "dark mode feature notification" effect when:
I will amend the existing implementation plan to include this feature introduction and add it to the task list. I'll also include the other changes I've made to the IP when drafting the issues, like those mentioned in #4308. |
We could include a third case: if user doesn't click on the banner or the switcher, both elements disappear after 2 weeks. What do you think? Both elements are not intrusive and that time span sounds reasonable to me. |
@fcoveram that is potentially a bit more complex to implement but is probably a good idea. Interestingly, I've also had a thought. We really only want to introduce a feature to existing users, right? For new users, they are unfamiliar with all of Openverse's functionality. So we also might want to:
|
I wasn't sure about this, but the more I think the idea, the more I like it. +1 to the suggestion. |
Does this mean the default theme for existing users will be "light" and not "system"? If I use dark mode on my computer and visit Openverse, having visited before, I would expect the light-themed site I know but it will be dark-themed (because of "system"). We also shouldn't make "light" the default for everyone though because for new users, it is a more pleasant experience to be served in their preferred OS level color theme. |
@dhruvkb The discussion on this issue predates the decision to use "system" as the default. But I am not understanding what you are asking.
Which would be explained by the feature introduction, correct? |
But also there is no need to introduce the feature anymore, the site is dark so I have been made aware that there is now dark mode.
|
Oh I follow you now 😆 That's fair, and I suppose it's a matter of what level of awareness and announcement is sufficient. @fcoveram what do you think? Is the feature introduction still necessary if we are defaulting to "system" by default? |
When you say the feature introduction, you mean the message on the homepage plus the glowing button? Regardless of the response, I'm still convinced that adding a visual sign in the UI indicating new features sets an appealing manner of product progress. As in other examples I've previously mentioned, we didn't include an indicator for landing on source, creator, and tag views. The feature awareness relies on users' ability to discover in the UI what's new. For other upcoming features, let's say filtering by color, users will need to discover it. |
My core point with the above is whether we want to introduce features through the UI. If the answer is no, then we will continue communicating the product changes through the existing channels (a post on Make and/or WordPress social media). |
I agree, and this is the information I was looking for. Thank you! |
Commenting to add a big +1 to what you've said @fcoveram that Zack quoted. We should absolutely highlight improvements and new features in ways that will be evident to users who may not even be aware that Openverse has a Make blog or social media. |
Designs for Dark mode project (#3592)
Description
In order to have users updated with the latest improvements on the search, I have the following idea.
The "what's new" message is displayed in a modal with a blurred background that shows an image or gif, text content introducing the feature, and one action to enable/explore the feature and one to close the overlay dialog.
For the dark mode feature, all texts are pending and need comms revision, and the visual placed above text content will show how the feature works in production (discussed in #4155).
Here is a prototype that simulates all interactions expected.
CleanShot.2024-04-18.at.16.15.36.mp4
Mockups
Figma file: Dark mode
The text was updated successfully, but these errors were encountered: