Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bespoke URLTextField in favor of base TextField #4320

Closed
AetherUnbound opened this issue May 13, 2024 · 0 comments · Fixed by #4322
Closed

Remove bespoke URLTextField in favor of base TextField #4320

AetherUnbound opened this issue May 13, 2024 · 0 comments · Fixed by #4322
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API

Comments

@AetherUnbound
Copy link
Collaborator

AetherUnbound commented May 13, 2024 •
edited
Loading

Description

PR #4315 introduced a new URLTextField to mirror Django's URLField (only using TextField as the base field rather than CharField). As @sarayourfriend pointed out in the PR, this code is largely superfluous and unnecessary because we do not write directly to these tables from the API.

We should remove this code and use a TextField directly on those fields instead.

Additional context
@AetherUnbound AetherUnbound added 💻 aspect: code Concerns the software code in the repository 🟧 priority: high Stalls work on the project or its dependents 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels May 13, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog May 13, 2024
@AetherUnbound AetherUnbound moved this from 📋 Backlog to 📅 To Do in Openverse Backlog May 13, 2024
@AetherUnbound AetherUnbound mentioned this issue May 13, 2024
Merged
8 tasks
@sarayourfriend sarayourfriend self-assigned this May 14, 2024
@sarayourfriend sarayourfriend moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog May 14, 2024
@sarayourfriend sarayourfriend mentioned this issue May 14, 2024
Merged
6 tasks
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary write-time validating URLTextField WordPress/openverse
2 participants
@AetherUnbound @sarayourfriend