-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sources table does not show the full URL in mobile size #470
Comments
Thank you for reporting this error, @kajalmultidots. The video is very helpful. |
Here are two ideas where I would like your thoughts. Stacked rowsStack each row when the screen reaches the
One benefit is that all info is displayed on the page without additional scroll bars. Even when columns are not sortable, I'm drawn to this solution as data is not in a comparison or evaluation context; in contrast to other spreadsheets like sales or number evolutions where cells side by side ease the table meaning. I found this example from this Smashing magazine post for reference. Scrollbar tableA second alternative could be to make the table scrollable horizontally and add a shadow indicating the scroll direction.
I personally don't like this alternative as on small screens the interaction feels clunky due to the bi-directional scrollbar in small screens. What do you think of this? Updates from Design LibraryIn addition to the above, I applied spacing tweaks based on the latest updates in the Design Library. The main changes are:
DesignsFigma file: Responsive source tables |
Hi @kajalmultidots, do you have any feedback concerning the design proposal for the issue you raised? @fcoveram, if we don't get any community feedback on this particular issue I think you can pick whichever you prefer and mark this ready for work. |
I greatly like the stacked rows; they look more appropriate for a small screen. Horizontal scrolling can sometimes be problematic on the phone, as Android uses that gesture to go back to pages or apps. |
Hi, Is this something I could help with? |
@szymon-polaczy It's up for grabs if you like! |
Great, in that case I'd like to snatch it |
Hi @zackkrida , sorry I missed your message. I think @fcoveram provided the design mockup is looks good. Great work @fcoveram 🎉 . Thanks all for your work 👍 |
Description
In the below URL, the table content is not showing properly in the responsive(320px) design.
Page URL: https://wordpress.org/openverse/sources/
For better understanding, I provided the Video attachment
Video URL: https://share.cleanshot.com/N09QQ0MzRdKvJ4fZkV8t
Thanks.
Implementation
Designs were cleaned-up for dev, and are ready for implementation.
Component to update:
frontend/src/components/VSourcesTable.vue
The text was updated successfully, but these errors were encountered: