Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources table does not show the full URL in mobile size #470

Closed
kajalmultidots opened this issue Jan 11, 2023 · 9 comments · Fixed by #4543
Closed

Sources table does not show the full URL in mobile size #470

kajalmultidots opened this issue Jan 11, 2023 · 9 comments · Fixed by #4543
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@kajalmultidots
Copy link

kajalmultidots commented Jan 11, 2023

Description

In the below URL, the table content is not showing properly in the responsive(320px) design.
Page URL: https://wordpress.org/openverse/sources/

For better understanding, I provided the Video attachment
Video URL: https://share.cleanshot.com/N09QQ0MzRdKvJ4fZkV8t

Thanks.

Implementation

Designs were cleaned-up for dev, and are ready for implementation.

Component to update: frontend/src/components/VSourcesTable.vue

@kajalmultidots kajalmultidots added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Jan 11, 2023
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 🕹 aspect: interface Concerns end-users' experience with the software and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 11, 2023
@krysal
Copy link
Member

krysal commented Jan 11, 2023

Thank you for reporting this error, @kajalmultidots. The video is very helpful.

@krysal krysal transferred this issue from WordPress/openverse Jan 11, 2023
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@obulat obulat added the design: needed Needs a designer's touch before implementation can begin label Aug 10, 2023
@obulat obulat changed the title Table Content overflow in responsive Sources table does not show the full URL in mobile size Aug 10, 2023
@fcoveram
Copy link
Contributor

Here are two ideas where I would like your thoughts.

Stacked rows

Stack each row when the screen reaches the sm breakpoint.

sm breakpoint xs breakpoint
Source page with stacked table in SM breakpoint Source page with stacked table in XS breakpoint

One benefit is that all info is displayed on the page without additional scroll bars. Even when columns are not sortable, I'm drawn to this solution as data is not in a comparison or evaluation context; in contrast to other spreadsheets like sales or number evolutions where cells side by side ease the table meaning.

I found this example from this Smashing magazine post for reference.

Scrollbar table

A second alternative could be to make the table scrollable horizontally and add a shadow indicating the scroll direction.

sm breakpoint xs breakpoint
Source page with a scrollable table in SM breakpoint Source page with a scrollable table in XS breakpoint

I personally don't like this alternative as on small screens the interaction feels clunky due to the bi-directional scrollbar in small screens.

What do you think of this?


Updates from Design Library

In addition to the above, I applied spacing tweaks based on the latest updates in the Design Library. The main changes are:

  • In 2xl / xl / lg
    • Content wrapper has a max-width of 768px
    • Margin top is 40px and bottom 96px
  • In md / sm
    • Margins: top is 20px, sides and bottom are 40px
  • In xs
    • Margins: top is 20px, sides are 24px, bottom is 40px

Designs

Figma file: Responsive source tables

@fcoveram fcoveram added design: in discussion Issue has a design that needs feedback and removed design: needed Needs a designer's touch before implementation can begin labels Dec 14, 2023
@fcoveram fcoveram self-assigned this Dec 14, 2023
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Dec 14, 2023
@krysal krysal moved this from 📅 To Do to 📋 Backlog in Openverse Backlog Jan 15, 2024
@AetherUnbound AetherUnbound moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Jan 26, 2024
@zackkrida
Copy link
Member

Hi @kajalmultidots, do you have any feedback concerning the design proposal for the issue you raised?

@fcoveram, if we don't get any community feedback on this particular issue I think you can pick whichever you prefer and mark this ready for work.

@krysal
Copy link
Member

krysal commented Mar 5, 2024

I greatly like the stacked rows; they look more appropriate for a small screen. Horizontal scrolling can sometimes be problematic on the phone, as Android uses that gesture to go back to pages or apps.

@fcoveram
Copy link
Contributor

fcoveram commented Mar 6, 2024

Seeing the mockups after a month of sharing them, and I agree with @krysal that stacked rows looks better. Let's go with that one.

Designs were cleaned-up for dev.

@fcoveram fcoveram added design: ready Issue with a mockup ready for implementation and removed design: in discussion Issue has a design that needs feedback labels Mar 6, 2024
@dhruvkb dhruvkb self-assigned this Apr 29, 2024
@zackkrida zackkrida assigned zackkrida and unassigned dhruvkb Apr 29, 2024
@szymon-polaczy
Copy link
Contributor

Hi, Is this something I could help with?

@krysal
Copy link
Member

krysal commented Jun 17, 2024

@szymon-polaczy It's up for grabs if you like!

@szymon-polaczy
Copy link
Contributor

Great, in that case I'd like to snatch it

@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Jun 27, 2024
@kajalmultidots
Copy link
Author

Hi @zackkrida ,

sorry I missed your message. I think @fcoveram provided the design mockup is looks good. Great work @fcoveram 🎉 .

Thanks all for your work 👍

@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: ready Issue with a mockup ready for implementation 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants