Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright e2e test e2e/preferences.spec.ts:112 › switchable features › switching fetch_sensitive from off saves state in a cookie is flaky #5001

Closed
obulat opened this issue Sep 28, 2024 · 0 comments · Fixed by #5015 or #5044
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Sep 28, 2024

Failed CI run: https://github.com/WordPress/openverse/actions/runs/11064395080/job/30742174454

trace.zip

I don't fully understand why this test fails. In the trace, you can see that the switch was clicked, but the input still has checked attribute, even after the check for .not.toBeChecked is successful.

For future reference, here's Playwright code for the checked attribute: https://github.com/dgozman/playwright/blob/main/packages/playwright-core/src/server/injected/injectedScript.ts

@obulat obulat added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Sep 28, 2024
@openverse-bot openverse-bot moved this to 📅 To Do in Openverse Backlog Sep 28, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 📋 Backlog in Openverse Backlog Sep 28, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Sep 28, 2024
@obulat obulat self-assigned this Oct 7, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Oct 7, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Oct 9, 2024
@openverse-bot openverse-bot moved this from ✅ Done to 🏗 In Progress in Openverse Backlog Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
1 participant