Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Renovate for pnpm dependencies and enable Dependabot instead #544

Closed
1 task
sarayourfriend opened this issue Jun 8, 2022 · 4 comments
Closed
1 task

Disable Renovate for pnpm dependencies and enable Dependabot instead #544

sarayourfriend opened this issue Jun 8, 2022 · 4 comments
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@sarayourfriend
Copy link
Collaborator

Problem

Our renovate configuration is still having trouble with not running the pnpmfile.cjs script and it keeps knocking TypeScript back down to a much older version.

Description

Instead of continuing to tinker with Renovate (which is a distraction at this point), we can just use dependabot for the pnpm dependencies and leave Renovate on for the rest (namely GH actions).

Alternatives

Turn off renovate completely for now and just use dependabot for everything in the frontend with the goal of eventually moving back to Renovate in the future when we have more bandwidth to tinker with the configuration and/or stand up an actual self-hosted Renovate instance for ourselves.

Additional context

Discussed by myself and @obulat here: WordPress/openverse-frontend#1503 (comment)

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Jun 8, 2022
@sarayourfriend sarayourfriend mentioned this issue Jun 8, 2022
Closed
1 task
@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon and removed 🟧 priority: high Stalls work on the project or its dependents labels Jun 28, 2022
@sarayourfriend
Copy link
Collaborator Author

I think this is actually high if not critical because renovate opens PRs that are unactionable in the frontend repository like WordPress/openverse-frontend#1502

It hasn't bothered us much yet but given renovate is configured to open update PRs monthly, we will probably get a slew of unactionable update PRs in a few days. This creates noise (which is distracting) and wastes time (because people have to close these PRs).

It's a one line change to at least disable renovate for JavaScript dependencies, even if we don't enable dependabot for them instead.

cc @WordPress/openverse-frontend

@sarayourfriend sarayourfriend mentioned this issue Jun 29, 2022
Merged
4 tasks
@zackkrida zackkrida added 🟥 priority: critical Must be addressed ASAP and removed 🟨 priority: medium Not blocking but should be addressed soon labels Jun 29, 2022
@krysal
Copy link
Member

krysal commented Jun 29, 2022

It seems that dependabot still does not support pnpm, see the package-ecosystem options.

There was already an attempt on our part before in WordPress/openverse-frontend#1170.

@zackkrida zackkrida added 🟨 priority: medium Not blocking but should be addressed soon and removed 🟥 priority: critical Must be addressed ASAP labels Jul 5, 2022
@sarayourfriend
Copy link
Collaborator Author

Oh right! That's the whole reason we went with Renovate in the first place 🤦 Well, at least we can just try to debug renovate against package.json. I think to do that we could open a branch that updates the configuration to always open PRs instead of only monthly and then run the workflow anytime the PR is pushed and continue to debug why the "self-hosted" renovate still isn't running the pnpmfile.cjs...

@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@stacimc
Correct order of None handling in Cleveland provider script (#544)
8ca6a23 
* Check for none before property access

* Add test
@sarayourfriend
Copy link
Collaborator Author

Superseded by #3312

@sarayourfriend sarayourfriend closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Nov 22, 2023
@dhruvkb dhruvkb moved this from ✅ Done to 🗑 Discarded in Openverse Backlog Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zackkrida @krysal @obulat @sarayourfriend