Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim leading/trailing whitespace from attribution copy button result #553

Closed
1 task
krysal opened this issue May 19, 2022 · 1 comment · Fixed by #4066
Closed
1 task

Trim leading/trailing whitespace from attribution copy button result #553

krysal opened this issue May 19, 2022 · 1 comment · Fixed by #4066
Assignees
@andrewscwei
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@krysal
Copy link
Member

krysal commented May 19, 2022 •
edited by AetherUnbound
Loading

Description

The text copied from Credit the creator section sometimes has newlines at the beginning (and some results will have more than others). Reported by @AetherUnbound.

Reproduction

  1. Visit this image
  2. Click the "copy" button for "Credit the creator" HTML or Plain text tab
  3. Paste the content into a text editor and notice the leading whitespace

Screenshots

See video in Chrome browser.

Additional context

Confirmed is an issue in WordPress/openverse-frontend#1437.

Resolution

  • 🙋 I would be interested in resolving this bug.
@krysal krysal added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels May 19, 2022
@krysal krysal mentioned this issue May 19, 2022
Closed
1 task
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@sarayourfriend
Add PR review reminder DAG (#553)
f5de3e2 
* [WIP] Add PR review reminder DAG

* Use requests directly instead of HttpHook

* Add unit tests and fix weekday calculation

* Use crontab config to only run on weekdays

* Move repos into a constant

* Reduce calls to base_repo_name

* Remove unnecessary template configuration

* Refine argument types

* Use session and rename var for masking

* Move files and reduce necessary calls

* Add unit tests and fix bugs

* Move files and clean up default dry_run values

* Correct Urgency types

* Remove unused function

* Add docs to test factory
@andrewscwei
Copy link
Contributor

I can try tackling this issue

@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Apr 8, 2024
@andrewscwei andrewscwei mentioned this issue Apr 8, 2024
Closed
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Apr 8, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to 📋 Backlog in Openverse Backlog Apr 8, 2024
@andrewscwei andrewscwei mentioned this issue Apr 8, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📋 Backlog to 🏗 In Progress in Openverse Backlog Apr 8, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewscwei andrewscwei

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
3 participants
@andrewscwei @krysal @obulat