Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace external artist links with links to the relevant creator search on Openverse #630

Closed
1 task
sarayourfriend opened this issue Jan 24, 2022 · 4 comments
Closed
1 task

Replace external artist links with links to the relevant creator search on Openverse #630

sarayourfriend opened this issue Jan 24, 2022 · 4 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: needed Needs a designer's touch before implementation can begin ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🔧 tech: vue Involves Vue.js

Comments

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Jan 24, 2022 •
edited by obulat
Loading

Problem

Rather than link to the external resource for the creator, which may or may not give the user quick access to the artist/creator's content, let's replace the links and mentions of creator names everywhere with links to the relevant Openverse search.

Description

According to @zackkrida we can use the following format to build the search link:

/search/audio?searchBy=creator&q=<creator name>&source=<creator source>

We need to include the source because there could be two separate creators by the same name on different sources and they should be distinguished (we don't want to misattribute).

We could also explore making the source clearer on the artist name to help disambiguate multiple sources coming back with the same creator name representing separate people.

We could also continue to include the external link to the creator's page on the source when it exists as a separate link (?).

This probably needs some extra thought from @panchovm on the UX side to make sure we're delivering the correct information and not making things more confusing.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🔧 tech: vue Involves Vue.js labels Jan 24, 2022
@fcoveram fcoveram self-assigned this Jan 24, 2022
@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Mar 18, 2022
@krysal
Copy link
Member

krysal commented May 2, 2022

I like this proposal of changing the link to an Openverse search, it will help to make these filters and their use known, although I still find it valuable to keep a link to the author's profile on the source somewhere, maybe in the Media Information section. Otherwise, we won't need to store this info in the catalog anymore and should modify all the API provider scripts.

@fcoveram fcoveram added the design: needed Needs a designer's touch before implementation can begin label May 3, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@obulat @AetherUnbound
Refactor NYPL script to use ProviderDataIngester class (#630)
9ed21eb 
* Refactor NYPL script to use DataIngester class
* Use topics as tags
* Fix getting the preferred image and lint
* Add a get_value_from_dict_or_list helper
* Add docs, clean up type_of_resource code
* Refactor get_value_from_dict_or_list
* Move Variable retrieval to __init__
* Add a test for get_value_from_dict_or_list

Signed-off-by: Olga Bulat <obulat@gmail.com>
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
@obulat obulat mentioned this issue Apr 27, 2023
Merged
2 tasks
@obulat
Copy link
Contributor

obulat commented Jun 6, 2023

@sarayourfriend, do you think we can close this issue in favor of the ones that will be created as part of the "Additional search views" proposal?

@sarayourfriend
Copy link
Collaborator Author

We could, yup! If you do, please add it to the project thread. We handled an existing issue similarly for the #377 project (specifically #750).

@obulat obulat mentioned this issue Jun 6, 2023
Closed
6 tasks
@obulat
Copy link
Contributor

obulat commented Jun 6, 2023

I added this issue to the Prior Art section in Project thread #410. Closing this as won't do.

@obulat obulat closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software design: needed Needs a designer's touch before implementation can begin ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🔧 tech: vue Involves Vue.js
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fcoveram @krysal @obulat @sarayourfriend