Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade catalog to Python 3.11 #663

Closed
dhruvkb opened this issue Nov 17, 2022 · 6 comments
Closed

Upgrade catalog to Python 3.11 #663

dhruvkb opened this issue Nov 17, 2022 · 6 comments
Assignees
@AetherUnbound
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs 🐍 tech: python Involves Python

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Nov 17, 2022

Problem

We should upgrade the Python version used in the project to Python 3.11.

Description

Python 3.11 has some nice new features and improvements so upgrading makes sense. It's also 10-60% faster (although our mileage may vary).

Changes will be needed in the following areas:

  • GitHub actions: actions/setup-python
  • Dockerfile
  • Pipfile
  • Pipfile.lock

Alternatives

We could continue to remain on Python 3.10 till it reaches EOL, although that's not a real alternative.
@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🐍 tech: python Involves Python labels Nov 17, 2022
@sahil-R
Copy link
Contributor

sahil-R commented Dec 22, 2022

Hey @dhruvkb can I work on this in January ?? if yes can you assign it to me??

@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 23, 2022 •
edited
Loading

Sure @sahil-R, this is not high priority and can definitely wait until January. Assigning to you.

@sahil-R
Copy link
Contributor

sahil-R commented Dec 23, 2022

Thank you @dhruvkb

@obulat obulat transferred this issue from WordPress/openverse-api Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@dhruvkb dhruvkb mentioned this issue Apr 20, 2023
Merged
8 tasks
@AetherUnbound AetherUnbound added ⛔ status: blocked Blocked & therefore, not ready for work 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: catalog Related to the catalog and Airflow DAGs and removed 🧱 stack: backend labels May 15, 2023
@AetherUnbound AetherUnbound self-assigned this May 15, 2023
@AetherUnbound
Copy link
Collaborator

Marking this as blocked - #1852 took care of all services but the catalog, which is blocked by Airflow. Once Airflow supports Python 3.11, we can tackle this and close it.

@obulat obulat moved this from 📋 Backlog to ⛔ Blocked in Openverse Backlog Jul 26, 2023
@sarayourfriend sarayourfriend removed 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server labels Aug 11, 2023
@dhruvkb
Copy link
Member Author

dhruvkb commented Aug 23, 2023

Airflow supports Python 3.11 since v2.6.2, released 2023-06-17. Since we're on a newer version already, we can consider this unblocked!

openverse/catalog/requirements_prod.txt

Line 5 in 5678bdc

apache-airflow[amazon,postgres,http]==2.6.3

@dhruvkb dhruvkb moved this from ⛔ Blocked to 📋 Backlog in Openverse Backlog Aug 23, 2023
@dhruvkb dhruvkb removed the ⛔ status: blocked Blocked & therefore, not ready for work label Aug 23, 2023
@sarayourfriend sarayourfriend mentioned this issue Apr 8, 2024
Closed
1 task
@sarayourfriend sarayourfriend changed the title Upgrade to Python 3.11 Upgrade catalog to Python 3.11 Apr 8, 2024
@sarayourfriend sarayourfriend removed the 🟩 priority: low Low priority and doesn't need to be rushed label Apr 8, 2024
@sarayourfriend sarayourfriend added the 🟨 priority: medium Not blocking but should be addressed soon label Apr 8, 2024
@AetherUnbound
Copy link
Collaborator

This has already been completed! (We're now on 3.12 😄)

openverse/catalog/requirements-prod.txt

Line 1 in 50fe56e

# PYTHON=3.12

@openverse-bot openverse-bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AetherUnbound AetherUnbound

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs 🐍 tech: python Involves Python
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AetherUnbound @obulat @dhruvkb @sarayourfriend @sahil-R