Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add skip-link ID to Skip to content anchor tag #7666

Conversation

Debarghya-Banerjee
Copy link

Trac Ticket: Core-62311

Summary

  • This pull request introduces an ID attribute to the "skip to content" link, enhancing accessibility for users navigating with assistive technologies. By adding id="skip-link", we ensure that this link can be targeted by "back to top" functionality, providing a seamless user experience.

Changes Made

  • Added id="skip-link" to the existing "skip to content" link.

Rationale

  • While the current implementation allows users to visually jump to the content, adding an ID ensures that:

  • The "skip to content" link can be easily referenced by other navigation elements, such as a "back to top" link.

  • When users activate these links, they receive proper focus, improving the overall accessibility of the site.

  • This small change can significantly enhance the experience for keyboard and screen reader users, making navigation more intuitive.

Impact

  • This update will improve compliance with accessibility standards and create a better user experience for all visitors, particularly those using assistive technologies.

Copy link

github-actions bot commented Oct 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @philliproth.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee, apermo, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@apermo apermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@Debarghya-Banerjee
Copy link
Author

Hi @joedolson, @sabernhardt

I have updated the id to wp-skip-link.

Can you please check?
Thanks.

@philliproth
Copy link

Hey @apermo @sabernhardt - would love to see this in 6.8 - thank you for reviewing!

@joedolson joedolson requested review from joedolson and removed request for sabernhardt December 23, 2024 22:38
@joedolson
Copy link
Contributor

In r59559

@joedolson joedolson closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants