-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Change docblock line wrapping to 120 characters #146
Comments
@johnbillion Changes to the coding standards need to be proposed on Make. |
I'll get something written up. In the meantime, I'm struggling to find anywhere that documents the process for proposing a change to the docs standards. Is it documented somewhere that I'm missing? |
I don't think there is an official process documented, but when we did the WPCS 3.0.0 changes that included tons of changes for the docs, we were doing them based on the proposal Juliette wrote. The proposal had a discussion, and based on this discussion we made changes, both in the handbook and in the WPCS itself. |
Indeed, but that was after we were told - in no uncertain terms - that any changes had to go via a proposal on Make. At some point in the distant past, there was an idea to have an RFC process, but that idea was killed before it ever got off the ground. 🤷♀ |
I am proposing that the "Line wrapping" guideline for docblocks in PHP and JavaScript files is changed so it is fixed at 120 characters. The current guideline is:
Issue Description
80 characters is very narrow. A large proportion of docblocks in WordPress core don't adhere to this, especially when it comes to
@param
tags with detailed documentation and array arguments which use the extended@type
syntax. If the line length limit is assumed to be 80 characters then it's possible for over half the length to be taken up before the description starts.URL of the Page with the Issue
Why is this a problem?
Docblocks in PHP and JavaScript files have line lengths of varying width. There is little consistency.
Suggested Fix
Let's set the recommended line length limit to 120 characters in all cases.
The text was updated successfully, but these errors were encountered: