Rename interface

Author: Thomas-M-Krystyan

EventsHandler/Api/EventsHandler/Program.cs

@@ -202,7 +202,7 @@ private static WebApplicationBuilder AddCustomServices(this WebApplicationBuilde
             builder.Services.RegisterClientFactories();
             builder.Services.AddSingleton<ITemplatesService<TemplateResponse, NotificationEvent>, NotifyTemplatesAnalyzer>();
             builder.Services.AddSingleton<ISendingService<NotificationEvent, NotifyData>, NotifySender>();
-            builder.Services.AddSingleton<IFeedbackService, ContactRegistration>();
+            builder.Services.AddSingleton<ITelemetryService, ContactRegistration>();
             builder.Services.RegisterResponders();
 
             return builder;

EventsHandler/Api/EventsHandler/Services/DataSending/NotifySender.cs

@@ -21,14 +21,14 @@ internal sealed class NotifySender : ISendingService<NotificationEvent, NotifyDa
         #endregion
 
         private readonly IHttpClientFactory<INotifyClient, string> _clientFactory;
-        private readonly IFeedbackService _telemetry;
+        private readonly ITelemetryService _telemetry;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="NotifySender"/> class.
         /// </summary>
         public NotifySender(
             IHttpClientFactory<INotifyClient, string> clientFactory,
-            IFeedbackService telemetry)
+            ITelemetryService telemetry)
         {
             this._clientFactory = clientFactory;
             this._telemetry = telemetry;

EventsHandler/Api/EventsHandler/Services/Telemetry/ContactRegistration.cs

@@ -17,13 +17,13 @@
 namespace EventsHandler.Services.Telemetry
 {
     /// <summary>
-    /// <inheritdoc cref="IFeedbackService" />
+    /// <inheritdoc cref="ITelemetryService" />
     /// <para>
     ///   Informs external "Contactmomenten" API web service about completion of sending notifications to "NotifyNL" API web service.
     /// </para>
     /// </summary>
-    /// <seealso cref="IFeedbackService" />
-    internal sealed class ContactRegistration : IFeedbackService
+    /// <seealso cref="ITelemetryService" />
+    internal sealed class ContactRegistration : ITelemetryService
     {
         private readonly IDataQueryService<NotificationEvent> _dataQuery;
 
@@ -35,8 +35,8 @@ public ContactRegistration(IDataQueryService<NotificationEvent> dataQuery)
             this._dataQuery = dataQuery;
         }
 
-        /// <inheritdoc cref="IFeedbackService.ReportCompletionAsync(NotificationEvent, NotifyMethods, string)"/>
-        async Task<string> IFeedbackService.ReportCompletionAsync(NotificationEvent notification, NotifyMethods notificationMethod, string message)
+        /// <inheritdoc cref="ITelemetryService.ReportCompletionAsync(NotificationEvent, NotifyMethods, string)"/>
+        async Task<string> ITelemetryService.ReportCompletionAsync(NotificationEvent notification, NotifyMethods notificationMethod, string message)
         {
             // NOTE: Feedback from "OpenKlant" will be passed to "OpenZaak"
             return await SendFeedbackToOpenZaakAsync(

EventsHandler/Api/EventsHandler/Services/Telemetry/Interfaces/IFeedbackService.cs renamed to EventsHandler/Api/EventsHandler/Services/Telemetry/Interfaces/ITelemetryService.cs

@@ -9,7 +9,7 @@ namespace EventsHandler.Services.Telemetry.Interfaces
     /// <summary>
     /// The service to collect and send feedback about the current business activities to the dedicated external API endpoint.
     /// </summary>
-    public interface IFeedbackService
+    public interface ITelemetryService
     {
         /// <summary>
         /// Reports to external API service that notification of type <see cref="NotifyMethods"/> was sent to "Notify NL" service.

EventsHandler/Tests/IntegrationTests/EventsHandler.IntegrationTests/Services/DataSending/NotifySenderTests.cs

@@ -91,7 +91,7 @@ public async Task SendEmailAsync_Calls_NotificationClientMethod_SendEmailAsync()
         public async Task SendSmsAsync_Calls_IFeedbackServiceMethod_ReportCompletionAsync()
         {
             // Arrange
-            Mock<IFeedbackService> mockedTelemetry = GetMockedTelemetry();
+            Mock<ITelemetryService> mockedTelemetry = GetMockedTelemetry();
             this._testNotifySender = GetTestSendingService(mockedTelemetry: mockedTelemetry);
             NotificationEvent testNotification = GetTestNotification();
 
@@ -110,7 +110,7 @@ public async Task SendSmsAsync_Calls_IFeedbackServiceMethod_ReportCompletionAsyn
         public async Task SendEmailAsync_Calls_IFeedbackServiceMethod_ReportCompletionAsync()
         {
             // Arrange
-            Mock<IFeedbackService> mockedTelemetry = GetMockedTelemetry();
+            Mock<ITelemetryService> mockedTelemetry = GetMockedTelemetry();
             this._testNotifySender = GetTestSendingService(mockedTelemetry: mockedTelemetry);
             NotificationEvent testNotification = GetTestNotification();
 
@@ -129,7 +129,7 @@ public async Task HttpClient_IsCached_AsExpected()
         {
             #region First phase of the test (HttpClient will be just created)
             // Arrange
-            Mock<IFeedbackService> mockedTelemetry = GetMockedTelemetry();
+            Mock<ITelemetryService> mockedTelemetry = GetMockedTelemetry();
             Mock<INotifyClient> firstMockedNotifyClient = GetMockedNotifyClient();
             var firstMockedClientFactory = new Mock<IHttpClientFactory<INotifyClient, string>>(MockBehavior.Strict);
             firstMockedClientFactory
@@ -180,7 +180,7 @@ public async Task HttpClient_IsCached_AsExpected()
         #region Helper methods
         private static ISendingService<NotificationEvent, NotifyData> GetTestSendingService(
             Mock<INotifyClient>? mockedClient = null,
-            Mock<IFeedbackService>? mockedTelemetry = null)
+            Mock<ITelemetryService>? mockedTelemetry = null)
         {
             var mockedClientFactory = new Mock<IHttpClientFactory<INotifyClient, string>>(MockBehavior.Strict);
             mockedClientFactory.Setup(mock => mock.GetHttpClient(It.IsAny<string>()))
@@ -210,9 +210,9 @@ private static Mock<INotifyClient> GetMockedNotifyClient()
             return notificationClientMock;
         }
 
-        private static Mock<IFeedbackService> GetMockedTelemetry()
+        private static Mock<ITelemetryService> GetMockedTelemetry()
         {
-            var mockedTelemetry = new Mock<IFeedbackService>(MockBehavior.Strict);
+            var mockedTelemetry = new Mock<ITelemetryService>(MockBehavior.Strict);
             mockedTelemetry.Setup(mock => mock.ReportCompletionAsync(
                     It.IsAny<NotificationEvent>(),
                     It.IsAny<NotifyMethods>(),