Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpunit tests #3

Open
jeroendesloovere opened this issue Jun 11, 2015 · 1 comment
Open

phpunit tests #3

jeroendesloovere opened this issue Jun 11, 2015 · 1 comment

Comments

@jeroendesloovere
Copy link
Contributor

Hi @WouterSioen,

I was just wondering if it would come in handy that tests are automatically executed when trying to commit. Sometimes we do not want to push commits that break our tests... But sometimes we do want this... what do you think?

@WouterSioen
Copy link
Owner

I'm mainly using this with Fork, which has unit tests and functional tests. I'd probably want the unit tests to run when committing (because they are fast), but I wouldn't want the functional tests to run, because this would slow development down a lot.

It could be possible to run a phpunit -c app --testsuite=unit, but this would tie this pre-commit script to the Fork implementation of unit tests. When I'm programming a Symfony project (which I do more and more), I may not have the same setup.

I'm thus not really a pro of adding this. (At least nog by default).

If I could find a way to check if we have the project structure of Fork and have a testsuite called unit, I would probably add this, but I'm not that good at bash scripting, so I'm not really sure (at this moment) if I could create this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants