Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of convertStringToHex/convertHexToString with stringToHex/hexToString #2698

Open
mvadari opened this issue May 22, 2024 · 3 comments

Comments

@mvadari
Copy link
Collaborator

mvadari commented May 22, 2024

convertStringToHex and convertHexToString are deprecated functions: https://github.com/XRPLF/xrpl.js/blob/main/packages/xrpl/src/utils/stringConversion.ts

These functions are really only still used in tests and snippets, so this is a pretty low priority issue. Just leaving it here as a reminder.

@Princeyadav05
Copy link

@mvadari can I give this one a try? I'm sure I would be able to tackle with your guidance.

@mvadari
Copy link
Collaborator Author

mvadari commented May 22, 2024

@mvadari can I give this one a try? I'm sure I would be able to tackle with your guidance.

Feel free, but I won't be able to provide any guidance.

@Princeyadav05
Copy link

@mvadari can I give this one a try? I'm sure I would be able to tackle with your guidance.

Feel free, but I won't be able to provide any guidance.

Sure, will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants