Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseTransactionFlags unintentionally mutates Transaction object #2823

Open
achowdhry-ripple opened this issue Nov 11, 2024 · 0 comments
Open

parseTransactionFlags unintentionally mutates Transaction object #2823

achowdhry-ripple opened this issue Nov 11, 2024 · 0 comments
Assignees
@achowdhry-ripple

Comments

@achowdhry-ripple
Copy link
Collaborator

https://github.com/XRPLF/xrpl.js/blob/main/packages/xrpl/src/models/utils/flags.ts#L100
This line of code mutates the provided Transaction object, which is an unexpected side effect from this function.

Use convertFlagsToNumber directly to eliminate this issue.

Also remove all usages of setTransactionFlagsToNumber with convertFlagsToNumber and deprecate the method.
@achowdhry-ripple achowdhry-ripple self-assigned this Nov 11, 2024
@achowdhry-ripple achowdhry-ripple changed the title parseTransactionFlags unintentionally mutates the passed in Transaction object parseTransactionFlags unintentionally mutates Transaction object Nov 11, 2024
@achowdhry-ripple achowdhry-ripple mentioned this issue Nov 13, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achowdhry-ripple achowdhry-ripple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achowdhry-ripple