Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xrpl4j for rippled v1.11 changes #433

Closed
sappenin opened this issue Jun 29, 2023 · 2 comments
Closed

Update xrpl4j for rippled v1.11 changes #433

sappenin opened this issue Jun 29, 2023 · 2 comments
Labels
breaking Introduces a breaking change from one version to the next. enhancement New feature or request
Milestone

Comments

@sappenin
Copy link
Collaborator

sappenin commented Jun 29, 2023

See new API changes in v1.11 of rippled here: https://github.com/orgs/XRPLF/projects/1/views/4

For each change, we should determine if a new xprl4j ticket is warranted.

Note: Depending on the API change, we may need to simply @deprecate in order to support older variants of rippled, but futher investigation is warranted.

@sappenin sappenin added breaking Introduces a breaking change from one version to the next. enhancement New feature or request labels Jun 29, 2023
@sappenin sappenin added this to the v3.0 milestone Jun 30, 2023
@sappenin
Copy link
Collaborator Author

sappenin commented Jul 7, 2023

Also see this for helpful changeset info: https://github.com/intelliot/rippled/blob/api-changelog/API-CHANGELOG.md

@nkramer44
Copy link
Collaborator

I believe this is complete. The things we needed to change in xrpl4j for rippled v1.11 were:

  1. Add account_flags object to account_info method response. This doesn't require any changes in xrpl4j because we already parse flags in AccountRootObject.
  2. Add support for NFTokenPages in account_objects RPC calls. This was done in Add objects for NFTokenPages #432
  3. Add support for NetworkID in transactions. This was done in Support for NetworkID #461
  4. Add nftoken_id, nftoken_ids and offer_id meta fields to NFT tx responses. This was done in Add nftoken_id, nftoken_ids, and offer_id fields to TransactionMetadata #463

Everything else in 1.11 was not an API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Introduces a breaking change from one version to the next. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants