[Bug] Colour glitches on start since last update

[ZiClaud]

Screencast.from.2024-12-10.09-23-44.mp4

It only happens when I have the page open

Screencast.from.2024-12-10.09-28-56.mp4

It also happens with other colours

[giwih]

I think for some reason the theme you selected is not saved, and color glitches are caused by another bug I fixed in - #304 , do you have any problems with saving other settings?

[ZiClaud]

I think for some reason the theme you selected is not saved, and color glitches are caused by another bug I fixed in - #304 , do you have any problems with saving other settings?

Nope, no problems with saves, just with the colour, and just on Firefox.
There's still the same problem while using https://xengshi.github.io/materialYouNewTab/, so I think that it's either because of some extension I use, or something like that.

Also, the same exact thing happens on mobile (I use the Firefox app).

[prem-k-r]

Is it fixed with recent PRs merging?
https://github.com/XengShi/materialYouNewTab/archive/refs/heads/main.zip

[ZiClaud]

Is it fixed with recent PRs merging? refs/heads/main.zip

I mean, sort of.
Now it won't appear the glitched theme, but it still resets the theme to the red one.
Also, the second attachment shows the console.

Screencast.from.2024-12-13.15-38-56.mp4

Screencast.from.2024-12-13.15-43-49.mp4

[itz-rj-here]

Is it fixed with recent PRs merging? refs/heads/main.zip

I mean, sort of. Now it won't appear the glitched theme, but it still resets the theme to the red one. Also, the second attachment shows the console.

Screencast.from.2024-12-13.15-38-56.mp4
Screencast.from.2024-12-13.15-43-49.mp4

Well it's also causing in the chrome browser too. :(

[prem-k-r]

That's odd..
It seems some issue with custom color

[giwih]

firefox has a different browser engine, firefox restores the last value of color picker, and when duplicate/open a new tab triggers EventListener, which updates the theme, the default color picker is #ea1010, if you put for example some purple, then when you open a new tab will be purple.

all chromium browsers:

firefox:

In general, firefox keeps triggering EventListener and that's why the theme is updated. If you remove these lines, everything will work (color picker will not work, of course).

materialYouNewTab/script.js

Line 1507 in 787a35f

colorPicker.addEventListener('input', handleColorPickerChange);