Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting Organisation class ENUM values in 2.x branch are now incomplete #384

Open
wallacio opened this issue Feb 2, 2025 · 2 comments

Comments

@wallacio
Copy link

wallacio commented Feb 2, 2025

SDK you're using

  • Version 2.23.x

Describe the bug
Valid organisation ENUMs have not been backported to 2.x branch, which I believe is still maintained and valid. An organisation which has the class 'COMPREHENSIVE' throws an exception in getOrganisation.

InvalidArgumentException: Invalid value for 'class', must be one of 'DEMO', 'TRIAL', 'STARTER', 'STANDARD', 'PREMIUM', 'PREMIUM_20', 'PREMIUM_50', 'PREMIUM_100', 'LEDGER', 'GST_CASHBOOK', 'NON_GST_CASHBOOK', 'ULTIMATE', 'LITE' in vendor/xeroapi/xero-php-oauth2/lib/Models/Accounting/Organisation.php:1508

Expected behavior
Valid ENUM values returned in Models\Accounting\Organisation::getClassAllowableValues() to be backported to 2.x branch (which I think is the last supported branch with firebase/php-jwt:5.x

Additional context
#351

Copy link

github-actions bot commented Feb 2, 2025

PETOSS-697

Copy link

github-actions bot commented Feb 2, 2025

Thanks for raising an issue, a ticket has been created to track your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant