move to opengl core profile #2467

totaam · 2019-10-31T08:15:07Z

More "modern" opengl.

Means using VBO for vertices, glVertexPointer etc
This may help with #2466, see also #3064

Links:

The text was updated successfully, but these errors were encountered:

totaam · 2023-04-05T15:55:08Z

Some links that might be useful:
https://github.com/vanrez-nez/awesome-glsl
https://github.com/eug/awesome-opengl

We may want to tackle webgl around the same time:
Xpra-org/xpra-html5#238
And perhaps look into vulkan too: #3064

totaam · 2023-10-20T13:27:13Z

92f0e86 was meant to help but triggered a NullFunctionError on glXCreateContextAttribsARB.

Perhaps the quads can be replaced with glBlitNamedFramebuffer: guide to modern opengl: glBlitNamedFramebuffer

painting rgb from a core context works now

totaam · 2023-10-22T15:42:10Z

Much progress thanks to A guide to using modern OpenGL functions : glBlitFramebuffer, as of 8b73c2b, we can paint rgb from a core context:

XPRA_OPENGL_CORE_PROFILE=1 xpra attach --encodings=rgb

Still TODO:

the fake pointer in draw_pointer will need to load an rgb image into the cursor texture
blend_texture (used by fps counter and pointer) will need to use a texture
draw_border and paint_box: use a texture since lines don't exist any more, then blit it 4 times?
paint_nvjpeg: pbo to fbo should be easy?
video: render_planar_update uses shaders, so use a vertex array?
pyopengl's detection of wayland isn't good enough: Attempt to auto-detect wayland vs. x11 (egl vs. glx) on linux mcfletch/pyopengl#41 (comment) so we have to set PYOPENGL_PLATFORM=egl if we are certain we want wayland (instead of going through xwayland - which may or may not work)

so it can stop processing of the event, or let it continue

and add a 'gtk' backend

totaam · 2023-10-25T16:32:53Z

As of 345a1cc, the experimental gtk opengl backend can be enabled with:

xpra attach --opengl=gtk

TODO:

conversion issues from move to opengl core profile #2467 (comment)
handle widget scaling
test with wayland, macos, win32
etc..

until it is fixed, don't use it on Wayland

which returns full details info

the callers to 'do_present_fbo' must set the rendering target

totaam · 2023-11-03T14:24:36Z

New items:

colorspace issues: some decoders do / don't need "narrow range" bt.601?
compile the shaders just once
- SVGA3D: can't call glDeleteProgram or glDeleteShader or glDeleteVertexArray!
SVGA3D has transparency issues - otherwise works? (move to grey list?)
upload cursor and border textures only when they change
vao: can keep just one, load it up early
fps not showing under wayland
play with Gtk.GLArea.set_auto_render

also fix lots of linter warnings

also fix call to glDeleteBuffers when cleaning up

so no need to use 'auto-render'

totaam · 2023-11-14T09:12:19Z

Telling MacOS that we want a core profile is obviously non-trivial..

MS Windows looks easier:

* revert 28eaf57: a warning is better than a crash * add option to require accelerated GL: 'XPRA_OPENGL_ACCELERATED=1' (defaults to 0) * no need to specify 'NSOpenGLPFAWindow' (it is the default) * only add 'NSOpenGLPFAAlphaSize' if we do need alpha, * move scale factor to the window context, since that's where it will be queried, * prefer 'native' to 'glarea' backend on MacOS

totaam · 2024-04-04T14:05:47Z

At last, c372a0a fixes MacOS the 'native' OpenGL backend.
(the GTK one is still buggy - doesn't seem to render at all..)
I'm not sure if the scaling problems are fixed, but this is tracked here: #4167

it's ugly, but at least it doesn't break the rendering like glBegin / glEnd

totaam · 2024-07-10T04:31:54Z

See also #4167 and scaling: 854f012 and 121df4c

totaam · 2024-08-13T09:58:18Z

It looks like using blit causes problems with scaling: #4324 (comment)

totaam · 2024-08-13T14:21:17Z

Important fixes related to FBOs and scaling: 32d9008, 617aa2e, 342dfa0 - for #4201 and #4324

totaam added v3.0.x client help wanted Extra attention is needed and removed v3.0.x labels Jan 22, 2021

totaam added this to the 5.0 milestone Jan 23, 2021

This was referenced Jan 23, 2021

opengl exception handler function #1770

Open

opengl YUVA support #1765

Closed

totaam added a commit that referenced this issue Oct 22, 2023

#2467 refactoring and toggle for glXCreateContextAttribsARB

e6b7ba8

totaam added a commit that referenced this issue Oct 22, 2023

#2467 enable arb context, but not core profile

4388c80

totaam added a commit that referenced this issue Oct 22, 2023

#2467 use glBlitFramebuffer instead of GL_QUADS

8b73c2b

painting rgb from a core context works now

This was referenced Oct 24, 2023

opengl SIGSEGV on macOS #4040

Closed

'EGLPlatform' object has no attribute 'GLX' #4036

Closed

GTK3 OpenGL win32 window is transparent #2466

Closed

totaam added a commit that referenced this issue Oct 25, 2023

#2467 split opengl init into a new method

f46ce27

totaam added a commit that referenced this issue Oct 25, 2023

#2467 let draw_fbo specify the return value

0f0f91a

so it can stop processing of the event, or let it continue

totaam added a commit that referenced this issue Oct 25, 2023

#2467 opengl switch can be used to choose a backend

345a1cc

and add a 'gtk' backend

totaam added a commit that referenced this issue Oct 26, 2023

#2467 try to continue without shaders

49b4c00

totaam added a commit that referenced this issue Oct 26, 2023

#2467 don't force x11 for opengl on wayland

27b9263

totaam added a commit that referenced this issue Oct 26, 2023

#2467 always make the gl context current before use

6e2276e

totaam added a commit that referenced this issue Oct 27, 2023

#2467: oops, don't override show flag

878d831

totaam added a commit that referenced this issue Oct 27, 2023

#2467: don't try to load the x11 bindings under (x)wayland

365c2b8

totaam added a commit that referenced this issue Oct 27, 2023

#2467 force 'egl' backend on Wayland

85b769c

totaam added a commit that referenced this issue Oct 27, 2023

#2467 YUV painting needs updating to use blitting

75c09a0

until it is fixed, don't use it on Wayland

totaam added a commit that referenced this issue Oct 27, 2023

#2467 better backend detection and setup

044f7ac

totaam added a commit that referenced this issue Oct 27, 2023

#2467 correct 'check_support' implementation

63663a7

which returns full details info

totaam added a commit that referenced this issue Oct 27, 2023

#2467 add patch to silence egl file open warning

05d1494

totaam added a commit that referenced this issue Nov 3, 2023

#2467 hook the gtk backend into the same present fbo

b56f3a8

the callers to 'do_present_fbo' must set the rendering target

totaam added a commit that referenced this issue Nov 5, 2023

#2467 'texture_pixel_format' is no longer needed

ff4e5e3

totaam added a commit that referenced this issue Nov 5, 2023

#2467 initialize the vao just once

4696b27

totaam added a commit that referenced this issue Nov 5, 2023

#2467 fix validation + link program

67ca529

also fix lots of linter warnings

totaam added a commit that referenced this issue Nov 5, 2023

#2467 validate early, fix linter warnings

66986f2

also fix call to glDeleteBuffers when cleaning up

totaam added a commit that referenced this issue Nov 8, 2023

#2467 it is safe to run opengl probing with Wayland now

abc5902

totaam added a commit that referenced this issue Nov 9, 2023

#2467 handle scaling in shaders

267339f

totaam added a commit that referenced this issue Nov 9, 2023

#2467 we have our own render buffer

ed139bd

so no need to use 'auto-render'

totaam added a commit that referenced this issue Nov 11, 2023

#2467 finally able to use only core context

1045635

totaam mentioned this issue Nov 14, 2023

hidpi awareness for macos #1933

Closed

totaam added a commit that referenced this issue Nov 17, 2023

#2467 disable opengl on MacOS until it is fixed

9593a19

totaam mentioned this issue Dec 5, 2023

more tools for helping users configure xpra #4064

Closed

totaam added a commit that referenced this issue Dec 24, 2023

#2467 we can probe opengl on Wayland now

ffd14c8

totaam mentioned this issue Jan 29, 2024

Monitor is almost totally transparent #3987

Closed

totaam added a commit that referenced this issue Mar 27, 2024

#2467 generate separate shaders for each pixel format

0c6fc0d

totaam added a commit that referenced this issue Apr 3, 2024

#2467 load default cursor from png, better than black square

6444ad2

totaam closed this as completed Apr 4, 2024

totaam mentioned this issue Apr 4, 2024

Problems with 4k screen #4167

Closed

totaam added a commit that referenced this issue Apr 5, 2024

#2467 proper resource cleanup

ca3f0d5

totaam added a commit that referenced this issue Apr 30, 2024

#2467 forgot to update the spinner to use a shader

006b777

it's ugly, but at least it doesn't break the rendering like glBegin / glEnd

totaam added a commit that referenced this issue May 1, 2024

#2467 use a shader for drawing the spinners

54a6f21

totaam mentioned this issue Jul 24, 2024

screen corruption/green on vscode #4305

Closed

totaam mentioned this issue Aug 13, 2024

xpra desktop has psychotic update habits in a local terminal #4319

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move to opengl core profile #2467

move to opengl core profile #2467

totaam commented Oct 31, 2019 •

edited

Loading

totaam commented Apr 5, 2023

totaam commented Oct 20, 2023 •

edited

Loading

totaam commented Oct 22, 2023 •

edited

Loading

totaam commented Oct 25, 2023

totaam commented Nov 3, 2023 •

edited

Loading

totaam commented Nov 14, 2023

totaam commented Apr 4, 2024

totaam commented Jul 10, 2024 •

edited

Loading

totaam commented Aug 13, 2024

totaam commented Aug 13, 2024

move to opengl core profile #2467

move to opengl core profile #2467

Comments

totaam commented Oct 31, 2019 • edited Loading

totaam commented Apr 5, 2023

totaam commented Oct 20, 2023 • edited Loading

totaam commented Oct 22, 2023 • edited Loading

totaam commented Oct 25, 2023

totaam commented Nov 3, 2023 • edited Loading

totaam commented Nov 14, 2023

totaam commented Apr 4, 2024

totaam commented Jul 10, 2024 • edited Loading

totaam commented Aug 13, 2024

totaam commented Aug 13, 2024

totaam commented Oct 31, 2019 •

edited

Loading

totaam commented Oct 20, 2023 •

edited

Loading

totaam commented Oct 22, 2023 •

edited

Loading

totaam commented Nov 3, 2023 •

edited

Loading

totaam commented Jul 10, 2024 •

edited

Loading