Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Adaptor AdaptorClosure and nodes part of public interface #125

Open
YarikTH opened this issue Aug 17, 2023 · 0 comments
Open

Make Adaptor AdaptorClosure and nodes part of public interface #125

YarikTH opened this issue Aug 17, 2023 · 0 comments

Comments

@YarikTH
Copy link
Owner

YarikTH commented Aug 17, 2023

Description

Currently all the stuff required to write your own adapters is hidden under private ureact::detail namespace. It means that it is unstable and can be silently changed every day. Some adapters can be written in terms of existing adapters, but it is quite limiting.

So, to allow user to freely extend the library, we need to expose at least all required building blocks. They are no needed by common inexperienced user, so adding them directly in ureact namespace is not convenient. Need to add additional namespace. Let's say ureact::core.

YarikTH added a commit that referenced this issue Sep 4, 2023
* move all adaptor.hpp content into a new public interface ureact::core
* rename all containing classes to official snake_case scheme
YarikTH added a commit that referenced this issue Sep 4, 2023
It allow to leave it in detail namespace while all other graph_interface.hpp content will be moved into core namespace
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_impl.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
* move all graph_interface.hpp content into a new public interface ureact::core
YarikTH added a commit that referenced this issue Sep 6, 2023
It allow to leave it in detail namespace while all other graph_interface.hpp content will be moved into core namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant