Bugfix: Crash when ysls definition is csharp, doesn't match any yarn names, and doesn't have a definition name.

pappleby · pappleby · commit 4b5af88c29ff · 2021-09-26T13:14:27.000-04:00
diff --git a/LanguageServer/src/Server/Workspace/Workspace.cs b/LanguageServer/src/Server/Workspace/Workspace.cs
@@ -94,8 +94,12 @@ public void Initialize(ILanguageServer languageServer = null)
                     fileEntry.Value.LookForUnmatchedCommands(isLastTime: true);
                 }
 
+
                 if (Configuration.DeepCommandLookup)
                 {
+                    // If we don't have a definition name, we'll never find it by yarn name (already found everything by yarn name before deep command lookup.)
+                    UnmatchedDefinitions = UnmatchedDefinitions.Where(d => d.DefinitionName.Any()).ToList();
+
                     foreach (var file in unusedCSharpFiles)
                     {
                         if (!UnmatchedDefinitions.Any())

Original file line number	Diff line number	Diff line change
`@@ -94,8 +94,12 @@ public void Initialize(ILanguageServer languageServer = null)`
`94`	`94`	`fileEntry.Value.LookForUnmatchedCommands(isLastTime: true);`
`95`	`95`	`}`
`96`	`96`
	`97`	`+`
`97`	`98`	`if (Configuration.DeepCommandLookup)`
`98`	`99`	`{`
	`100`	`+ // If we don't have a definition name, we'll never find it by yarn name (already found everything by yarn name before deep command lookup.)`
	`101`	`+ UnmatchedDefinitions = UnmatchedDefinitions.Where(d => d.DefinitionName.Any()).ToList();`
	`102`	`+`
`99`	`103`	`foreach (var file in unusedCSharpFiles)`
`100`	`104`	`{`
`101`	`105`	`if (!UnmatchedDefinitions.Any())`