Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity: Dialogue Advance Input doc page instructs to put the Dialogue Advance Input component on a new game object instead of the Line View #57

Open
hsandt opened this issue Jul 24, 2024 · 0 comments

Comments

@hsandt
Copy link

hsandt commented Jul 24, 2024

Page: https://docs.yarnspinner.dev/using-yarnspinner-with-unity/components/dialogue-view/dialogue-advance-input

says:

Dialogue Advance Input isn't a Line View itself, but it's designed to work with other line views, to interrupt and control the flow of dialogue.

To use a Dialogue Advance Input, create a new game object, and attach a Dialogue Advance Input component to it using the Add Component button.

instructs to put the Dialogue Advance Input component on a new game object. But looking at the code:

        internal void Start()
        {
            if (dialogueView == null)
            {
                dialogueView = GetComponent<DialogueViewBase>();
            }
            ...
        }

it should be placed on a game object that already has some DialogueViewBase child class component. In this case, the Line View with a LineView component, on the Dialogue System prefab instance.

I tried it and it worked. It should be explained, esp. as there is also the Options List View game object with an OptionsListView component that inherits from DialogueViewBase.

@hsandt hsandt changed the title Dialogue Advance Input doc page instructs to put the Dialogue Advance Input component on a new game object instead of the Line View Unity: Dialogue Advance Input doc page instructs to put the Dialogue Advance Input component on a new game object instead of the Line View Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant