Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change reference table in LineProvider at runtime #275

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change reference table in LineProvider at runtime #275

wants to merge 2 commits into from

Conversation

unknowndevice
Copy link
Contributor

  • Please check if the pull request fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
    • Does it pass all existing unit tests without modification?
      • If not, what did you change?
      • If you altered it significantly, what coverage issue did you fix?
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated to describe this change
  • What kind of change does this pull request introduce?
  • Bug Fix
  • Feature
  • Something else
  • What is the current behavior?

Right now you have to set the table before UnityLocalisedLineProvider.cs Starts.

  • What is the new behavior (if this is a feature change)?

You can now set the table at runtime.

  • Does this pull request introduce a breaking change?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@unknowndevice