From b1118433b10c06a6f15b668d2f5c184115d701e5 Mon Sep 17 00:00:00 2001 From: Eman Elsabban Date: Thu, 25 Jan 2024 12:40:07 -0800 Subject: [PATCH] removing return and adding comment for handling defer being none --- tron/kubernetes.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tron/kubernetes.py b/tron/kubernetes.py index 3acb0703d..316cc0888 100644 --- a/tron/kubernetes.py +++ b/tron/kubernetes.py @@ -356,17 +356,18 @@ def handle_next_event(self, _=None) -> None: self.deferred = self.queue.get() if self.deferred is None: log.warning("Unable to get a handler for next event in queue - this should never happen!") - return + # TODO: figure out how to recover if we were unable to get a handler + # Not adding a callback is very bad here as this means we will never handle this event # we want to process the event we just popped off the queue, but we also want # to form a sort of event loop, so we add two callbacks: # * one to actually deal with the event # * and another to grab the next event, in this way creating an event loop :) - self.deferred.addCallback(self.process_event) - self.deferred.addCallback(self.handle_next_event) + self.deferred.addCallback(self.process_event) # type: ignore + self.deferred.addCallback(self.handle_next_event) # type: ignore # should an exception be thrown, these callbacks will be run instead - self.deferred.addErrback(logError) - self.deferred.addErrback(self.handle_next_event) + self.deferred.addErrback(logError) # type: ignore + self.deferred.addErrback(self.handle_next_event) # type: ignore def process_event(self, event: Event) -> None: """