Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Editor: Very long sounds cause the playback timer to cut off digits #1466

Closed
iampremo opened this issue Jul 31, 2023 · 4 comments
Closed
Assignees
Labels
ide-bug Bugs with the GameMaker IDE import An issue imported from the old database
Milestone

Comments

@iampremo
Copy link
Member

iampremo commented Jul 31, 2023

If you load a long sound into the editor (17+ minutes), the digits become cut-off by the playback bar.

Expected Change

The current-time/total-time resizes dynamically to show all digits depending on the length of the sound.

Steps To Reproduce

  1. Start GMS2 and open/create a project
  2. Import a long audio file, something longer than 1000.00 seconds
  3. Open the Sound Editor
  4. Set the playback position to around half-way
  5. Play the sound
  6. Observe that the current-time is obscured by the playback bar
@toby-yoyo toby-yoyo self-assigned this Nov 11, 2024
@toby-yoyo toby-yoyo moved this to In Progress in Team Workload Nov 13, 2024
@toby-yoyo toby-yoyo added this to the 2025.1 milestone Nov 14, 2024
@toby-yoyo
Copy link

Reduced the position/duration precision of sounds that are at least 1000s to one decimal place.

Note that this issue also applied to the sound inspector and sound mixer modules.

For testing, one can generate a tone of any length in Audacity (under Generate -> Tone).

@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Nov 14, 2024
@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Nov 14, 2024
@Emc1923 Emc1923 self-assigned this Jan 7, 2025
@Emc1923
Copy link

Emc1923 commented Jan 7, 2025

I'm still having this issue on my laptop with default DPI

Image
Image

@Emc1923 Emc1923 reopened this Jan 7, 2025
@Emc1923 Emc1923 moved this from Triage to Todo in Team Workload Jan 8, 2025
@toby-yoyo toby-yoyo moved this from Todo to In Progress in Team Workload Jan 9, 2025
@toby-yoyo toby-yoyo moved this from In Progress to Todo in Team Workload Jan 9, 2025
@toby-yoyo toby-yoyo moved this from Todo to In Progress in Team Workload Jan 27, 2025
@toby-yoyo
Copy link

  • Slightly increased the widths of the grid columns containing duration labels in the sound editor and sound mixer.
  • Added a small left offset to the duration label in the sound editor to center it a little better when at its largest size.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Jan 27, 2025
@Emc1923
Copy link

Emc1923 commented Jan 29, 2025

Verified as of IDE v2024.1300.0.732 Runtime v2024.1300.0.743

@Emc1923 Emc1923 moved this from Done to Verified in Team Workload Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide-bug Bugs with the GameMaker IDE import An issue imported from the old database
Projects
Status: Verified
Development

No branches or pull requests

3 participants