Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-Game: [YYC] collision_rectangle() causes silent crash in early 2024.800 runtimes #7075

Closed
tabularelf opened this issue Aug 2, 2024 — with GM Bug Reporter · 8 comments
Assignees
Labels
project This issue has a sample project attached runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Milestone

Comments

@tabularelf
Copy link

tabularelf commented Aug 2, 2024

Description

While testing one of my games, I noticed that collision_rectangle_list was causing a silent crash. Replicated the issue with what I believe might be the case.

Steps To Reproduce

  1. Run project on YYC
  2. See crash in output

Which version of GameMaker are you reporting this issue for?

IDE v2024.800.0.602 Runtime v2024.800.0.624

Which operating system(s) are you seeing the problem on?

Windows 10.0.19045.0

Which platform(s) are you seeing the problem on?

Windows

32557554-d163-488b-885d-b4e4c8ce0427

@gm-bug-reporter gm-bug-reporter bot added runner-bug In-game bugs with the "GameMaker Studio 2" runtimes project This issue has a sample project attached labels Aug 2, 2024
@stuckie stuckie moved this from Triage to Todo in Team Workload Aug 6, 2024
@stuckie stuckie added this to the 2024.8 milestone Aug 6, 2024
@jackerley
Copy link

Fixed, same issue as #6767

@jackerley jackerley closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Workload Aug 6, 2024
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Not Planned in Team Workload Aug 6, 2024
@YYDan YYDan changed the title [YYC] collision_rectangle causes silent crash In-Game: [YYC] collision_rectangle() causes silent crash in early 2024.800 runtimes Aug 8, 2024
@YYDan YYDan moved this from Not Planned to Done in Team Workload Aug 8, 2024
@YYDan YYDan closed this as completed Aug 8, 2024
@YYDan YYDan moved this from Done to Ready for QA in Team Workload Aug 8, 2024
@alicemoretti
Copy link
Contributor

Verified fixed on IDE v2024.800.0.605 Runtime v2024.800.0.628.

Thank you.

@alicemoretti alicemoretti moved this from Ready for QA to Verified in Team Workload Aug 8, 2024
@danieltjewett
Copy link

danieltjewett commented Jan 27, 2025

I am still getting silent crashes in both YYC and VM with collision_rectangle_list on runtime v2024.8.1.218 and v2024.11.0.226:

Image

var num = selectMultiple || !hasNextTargetAvailable ?
		collision_rectangle_list(global.camera.view_left, global.camera.view_top, global.camera.view_left + global.camera.view_width, global.camera.view_top + global.camera.view_height, obj_Interactable, false, true, _tempList1, true)
		: 0;

Edit: This is 100% reproducible in our production demo on Steam (currently on runtime v2024.8.1.218). Steps are a little bit of a slog, but what I did to get the screenshot above:

  1. After booting into the game, mash the A button 20 times to skip the tutorial.
  2. Run to the Remembrance Ceremony. Mash B to skip the dialog.
  3. Try to beat the Violets and fail.
  4. Mash B to get through the Hospital scene.
  5. I don't think this is required, but I talk to the hospital lady after the scene.
  6. After this, I press Start to open Inventory, B to bring up Main Menu, and then Quit to Title Screen. Game Crashes.

@KormexGit
Copy link

@danieltjewett Would probably be good to make a new report, comments on closed reports don't usually get seen in my experience

@danieltjewett
Copy link

@KormexGit Are you experiencing this issue by chance? I'll most likely make an issue later tonight or tomorrow. We're working out the kinks of upgrading to 2024.11 after being on 2024.2 for several months.

@KormexGit
Copy link

@danieltjewett A simple test of just calling collision_rectangle_list does not crash for me, so if I were to guess there's some additional condition required that your project has happening

@danieltjewett
Copy link

@KormexGit Agreed. We're using collision_rectangle_list all over the place. That is why I haven't created an issue yet. That specific usage is on a clean up / game restart event, so maybe it has something to do with that? I still need to investigate.

I have found that it is easier for the team to have easily reproducible bugs than what I posted above. My posting above is for searching in Github, if someone else ever were to encounter the issue. I will link the new issue (once I find more) here as well.

@danieltjewett
Copy link

danieltjewett commented Jan 28, 2025

Upon further investigation, this code of ours shouldn't even be running, because we have a flag set that should gate this on game end. However, this gate is [obviously] not working correctly. My assumption is that global.camera or _tempList1 has been destroyed, and thus why the crash is happening. I'd like to see this throw an error, and not a silent crash. However, the complexity of this is not worth trying to figure out, and may not even be related to the issue posed in the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project This issue has a sample project attached runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Projects
Status: Verified
Development

No branches or pull requests

7 participants