Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestFramework: "draw_tilemap" in BasicTilemapTestSuite draw_tilemap(), failed draw buffer comparison #8242

Closed
sihammill opened this issue Oct 31, 2024 · 2 comments
Assignees
Labels
runner-bug In-game bugs with the "GameMaker Studio 2" runtimes TestFramework
Milestone

Comments

@sihammill
Copy link

sihammill commented Oct 31, 2024

Workflow Artefact URL

https://github.com/YoYoGames/GM-TestFramework/actions/runs/11610157668#artifacts

Test Code

// Test that draw_tilemap() draws the tilemap correctly using the draw comparison functions in objTestAsyncDraw:
// Start drawing to a test surface
testSurface = start_draw_comparison();
// draw the tilemap at 0,0
draw_tilemap(layerTilemap, 0, 0);
// Stop drawing to the test surface, store it as a buffer, then compare it against the drawTilemapTestExpectedBuffer file
end_draw_comparison(testSurface, "drawTilemapTest", "draw_tilemap(), failed draw buffer comparison");
			

Output From The Test

Testsuite Name: BasicTilemapTestSuite
Test Name: draw_tilemap
description: draw_tilemap(), failed draw buffer comparison
title: Assert buffers to be equal (MD5 hash)
stack: gml_Script_end_draw_comparison:108
actual: "5b59514d9527e1b25a6da54c9c87ab3b"
expected: "5f2985c9d87a402b0009273bcc21d2b4"

Runtime Version

2024.1100.0.689

Location Of The Test

https://github.com/YoYoGames/GM-TestFramework/blob/85e03a71e87b23cffb3b93b42b18081307cf2f09/projects/xUnit/scripts/BasicTilemapTestSuite/BasicTilemapTestSuite.gml#L728

Which platform(s) are you seeing the problem on?

Windows

@sihammill sihammill added runner-bug In-game bugs with the "GameMaker Studio 2" runtimes TestFramework labels Oct 31, 2024
@sihammill sihammill changed the title TestFramework: "TestFramework: "string_ext_test #4.1" in BasicTilemapTestSuite draw_tilemap(), failed draw buffer comparison TestFramework: "draw_tilemap" in BasicTilemapTestSuite draw_tilemap(), failed draw buffer comparison Oct 31, 2024
@iampremo iampremo moved this from Triage to Backlog in Team Workload Nov 5, 2024
@jackerley jackerley assigned JonnoRobson and unassigned jackerley Nov 6, 2024
@jackerley jackerley added this to the 2025.1 milestone Nov 6, 2024
@sihammill sihammill self-assigned this Jan 6, 2025
@jackerley
Copy link

Fixed by updates to the testing mechanism YoYoGames/GM-TestFramework#185

@github-project-automation github-project-automation bot moved this from Backlog to Done in Team Workload Jan 30, 2025
@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Jan 30, 2025
@sihammill
Copy link
Author

Fix verified in Runtime v2024.1300.0.746

@sihammill sihammill moved this from Ready for QA to Verified in Team Workload Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runner-bug In-game bugs with the "GameMaker Studio 2" runtimes TestFramework
Projects
Status: Verified
Development

No branches or pull requests

3 participants