Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefab Library: Duplicating a prefab should put the new assets inside a folder which has the prefab's name #8353

Closed
DragoniteSpam opened this issue Nov 9, 2024 · 6 comments
Assignees
Labels
feature request New feature (or a request for one)
Milestone

Comments

@DragoniteSpam
Copy link

Is your feature request related to a problem?

right now when you add a prefabinated asset to a project, it goes into a folder like Sounds/Whatever... or Sprites/Whatever... in the asset browser, and if you add a bunch of assets from different prefabs they'll all pile up in that folder and make a mess

Image

this is going to be a pain if you have more than two or three prefabs in a project, it would be much more helpful if they go into a folder like PackageName/Sounds/Whatever... by default

Describe the solution you'd like

Local Asset Packages already do this:

Image

Describe alternatives you've considered

No response

Additional context

No response

@DragoniteSpam DragoniteSpam added the feature request New feature (or a request for one) label Nov 9, 2024
@yerumaku
Copy link

Is this what a separate folder is for when importing files?

Now it works the same way it used to with the library.

the documentation say what should work differently?

@stuckie stuckie self-assigned this Nov 11, 2024
@stuckie stuckie moved this from Triage to Todo in Team Workload Nov 11, 2024
@stuckie stuckie added this to the 2025.1 milestone Nov 11, 2024
@YYDan YYDan changed the title Prefab manager puts assets in a generic folder instead of in a folder with the prefab name Prefab Library: Importing a prefab should put the new assets inside a folder which has the prefab's name Nov 11, 2024
@stuckie
Copy link

stuckie commented Nov 19, 2024

This is just a fallout from most local packages providing a folder within where all the assets are stored for that package.
A Prefab Collection is generally an entire project, so everything is at the root... we can just use the Prefab Collection's name in this instance and it'll work the same way.

@DragoniteSpam
Copy link
Author

By that do you mean that it should fall on the prefab creator to stick all of their assets in their own folder? I suppose that's how local packages work already

@yerumaku
Copy link

yerumaku commented Dec 5, 2024

I suppose that's how local packages work already

I believe that local packages are simply not added to the game directly, as they are now (an outdated copy option). Prefabs in the future should allow you to reference your resources without copying them directly to the project, for example, you have a constructor that lies in the prefab, you use alias to access the package + the name of the constructor, and it will be added to the project for parsing and assembly. Everything that the specified constructor uses from its library will also be included in the game during assembly, but nothing will be displayed inside the project directories.

I believe we will see this feature later, after architectural improvements, and most likely only for GMRT, no one has stated this for 2024.13, and I believe that this is impossible for YYC, and today's copying capabilities into the project are a repetition of the old functionality.

In theory, there is no reason not to put all assets when copying into a separate top-level directory, I think this function may appear, and I hope there will be a choice how to copy:

  • along the default package paths,
  • into a directory with the package name,
  • into a directory of your choice.

@stuckie stuckie changed the title Prefab Library: Importing a prefab should put the new assets inside a folder which has the prefab's name Prefab Library: Duplicating a prefab should put the new assets inside a folder which has the prefab's name Dec 5, 2024
@stuckie stuckie moved this from Todo to In Progress in Team Workload Feb 4, 2025
@zreedy zreedy closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Workload Feb 4, 2025
@gurpreetsinghmatharoo gurpreetsinghmatharoo moved this from Done to Ready for QA in Team Workload Feb 5, 2025
@Emc1923
Copy link

Emc1923 commented Feb 5, 2025

Verified as of IDE v2024.1300.0.737 Runtime v2024.1300.0.747.

@Emc1923 Emc1923 moved this from Ready for QA to Verified in Team Workload Feb 5, 2025
@stuckie
Copy link

stuckie commented Feb 6, 2025

Just to clarify the above as there's a bit of confusing information on this thread.

Local Packages and Prefab Collections, while similar, act in different ways.

A Local Package presents an entire Project ( or at least, the structured Project the Local Package Author has defined at export time ) that you can pick and choose assets from, and can import into your own Project. This is a one-way operation, and you can think of it as duplicating from the Local Package into your Project. If you want to use the assets in the Local Package in multiple projects, you need to re-import that into each of your projects.

A Prefab Collection is also a Project, but it presents a curated set of assets that the Prefab Author has chosen to make available in the Prefab Library. There may be other assets in the Project, that the exposed ones can talk to, but you can't directly interact with. When you drag a Prefab Asset from the Prefab Library into your Project, you are linking it. The Asset is still in the Prefab Collection, you are just referencing it in your own Project. This allows the same Prefab Asset to be used in multiple project, without being copied to each project manually.
However, you can also duplicate a Prefab Asset into your project, which works exactly the same way as importing an asset from a Local Package in that it creates a copy of it in your Project.
Both are valid choices in how you want to organise your project, hence why they are both offered.

There is additional functionality coming for 24.13, but we have not finished it as yet, so I wouldn't speculate on what is or is not coming and just have some patience, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature (or a request for one)
Projects
Status: Verified
Development

No branches or pull requests

4 participants