Building Projects: Particle Systems can get stuck on their "remove unused assets" check and cause builds to fail in 2024.11

[gm-bug-reporter]

Description

Hi there, I just updated to the newest IDE and Runtime(IDE 2024.11.0.179, Runtime 2024.11.0.227) from the August ones (IDE 2024.8.1.171, Runtime 2024.8.1.218).

Sadly I'm now getting compile errors with at least one of my Games.
The Output log has some lines that repeat a couple thousand times:

Found Project Format 2
+++ GMSC serialisation: SUCCESSFUL LOAD AND LINK TIME: 418.736ms
Loaded Project: PlatformerGIT
finished.
Stack overflow.
Repeat 4172 times:

at GMAssetCompiler.GameMaker.GMPSEmitter.OnUsed()
at GMAssetCompiler.GMResource.set_Used(Boolean)

at GMAssetCompiler.GameMaker.GMParticleSystem.OnUsed()
at GMAssetCompiler.GMResource.set_Used(Boolean)
at GMAssetCompiler.Loader.Load(System.String)
at GMAssetCompiler.Program.GetAssetsFile(System.Collections.Generic.List1<System.String>) at GMAssetCompiler.Program.Main(System.String[]) at System.RuntimeMethodHandle.InvokeMethod(System.Object, Void**, System.Signature, Boolean) at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(System.Object, System.Span1<System.Object>, System.Reflection.BindingFlags)
at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo)
at System.Reflection.MethodBase.Invoke(System.Object, System.Object[])
at Igor.Program.ExecuteAssetCompiler(System.String)
at Igor.Program.SetupBuildEnv(System.String, System.String, System.String, System.String, System.String, System.String, System.String, System.String, System.String, Boolean)
at Igor.Program.Main(System.String[])
elapsed time 00:00:02.9769294s for command "C:\ProgramData\GameMakerStudio2\Cache\runtimes\runtime-2024.11.0.227/bin/igor/windows/x64/Igor.exe" -j=8 -options="C:\Users\USER\AppData\Local\GameMakerStudio2\GMS2TEMP\build.bff" -v -- Windows Run started at 12/30/2024 21:37:29
FAILED: Run Program Complete
For the details of why this build failed, please review the whole log above and also see your Compile Errors window.

The compile errors window stays empty.

Same Error appears when cleaning the cache using the broom

I have tried to reinstall the old version to find out that there the compile works without issue, which I deduced from that the issues that feather shows shoudn't be an issue.

Though weirdly a different project of mine seems to work without issue.
I know in this project I use json_parse(), which has been changed in this update and in the other game I don't, though the Legacy behaviour options are enabled by default. I have tried enabling / disabling these.
Same behaviour with the v2024.11.0.226 Runtime.

I also tried this on my Laptop, same behaviour

Steps To Reproduce

Compiling the game

Which version of GameMaker are you reporting this issue for?

IDE v2024.11.0.179 Runtime v2024.11.0.227

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

Which platform(s) are you seeing the problem on?

Windows

9df6d81d-a6b4-4508-80b2-817fa27d0f97

[NickDerMitHut]

Update: It was the particle system called ParticleSystem1

Weird thing is, that this particle system isn't ever used in the game, deleting this, fixed the issue.

Edit:
It was also just this very specific, never used Particle system. I don't understand why it didn't cause any issues before, it seems to be just cursed I guess.

[thennothinghappened]

I've had an issue with a "cursed" asset in 2024.11 too, interestingly. Renaming the problem asset resolved it. Unfortunately I was not able to find any obvious reproduction steps for the issue, it just randomly happened. My bet is on a screwed up YY file, and some weird interaction with the new unused asset removal system (though, in my case, turning this off didn't seem to have any effect, though I wasn't really convinced it actually did turn off when telling it to.)

Here's a screenshot I took at the time - in my case it was a texture atlas sprite. Renaming from sAtlas to sAtlass as a test resolved the issue immediately:

...this is GM's "oh no" fallback texture.

[NickDerMitHut]

I've had an issue with a "cursed" asset in 2024.11 too, interestingly. Renaming the problem asset resolved it. Unfortunately I was not able to find any obvious reproduction steps for the issue, it just randomly happened. My bet is on a screwed up YY file, and some weird interaction with the new unused asset removal system (though, in my case, turning this off didn't seem to have any effect, though I wasn't really convinced it actually did turn off when telling it to.)

Here's a screenshot I took at the time - in my case it was a texture atlas sprite. Renaming from sAtlas to sAtlass as a test resolved the issue immediately:

...this is GM's "oh no" fallback texture.

Interesting. I didn't have that "unused asset removal" feature on anyway, so I don't know if it is that.
If its on, I think it also shows which assets its deemed to be unused in the console when exporting, so I guess that'd be a way of know if its actually of or not.

I also tried renaming that ParticleSystem that caused my issues but that didn't help. When I deleted that, and created a new unused ParticleSystem that worked without issue. So yeah, a screwed up YY file seems likely

[Emc1923]

Verified fixed in IDE v2024.1300.0.732 Runtime v2024.1300.0.743.