Preferences: "Apply" after changing the colour of a Code Editor 2 scope changes it to a different colour

[KormexGit]

Description

If you change a scope color in the theme editor, hitting apply will make it change to some other completely different color.

GameMaker-Beta_xo3IFjX7VQ.mp4

Steps To Reproduce

Change a scope color in the theme editor, then hit apply.

Which version of GameMaker are you reporting this issue for?

IDE v2024.1300.0.720 Runtime v2024.1300.0.733

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

405994a7-e065-4e16-95f3-9df3c5309049

[KormexGit]

GameMaker-Beta_6wke336Ohl.mp4

Looks like it's actually the color picker failing to update properly: It's setting the color to whatever your very first click on the color picker gives you. Can see the actual code color changes before hitting apply, but only to the first color clicked.

[zreedy]

Fixed. Theme was being Refreshed upon every dirtying of the model state. Refreshing means serialize to disk the current theme, then deserializing from disk all themes and updating the singleton TmTheme. A stale reference was retained from the old singleton value resulting in its serialization to disk without the most recent changes.

[mgeddesGM]

verified as of IDE v2024.1300.0.730 Runtime v2024.1300.0.741