Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Editor 2: Duplicated child objects do not highlight as inheriting from the parent properly until reload #9128

Open
KormexGit opened this issue Jan 22, 2025 — with GM Bug Reporter · 1 comment
Assignees
Labels
ide-bug Bugs with the GameMaker IDE project This issue has a sample project attached
Milestone

Comments

@KormexGit
Copy link

KormexGit commented Jan 22, 2025

Description

If you duplicate a child object, the duplicate won't highlight any of the parent's variables in any events. Additionally, if you rename the duplicate, feather will start showing a GM2040 error on any event_inherited calls, saying that the object has no parent with that event even though it does.

16AyV01VCn.mp4

Steps To Reproduce

  1. Create two objects, make one the child of the other.
  2. Set up some variables in the create event of the parent.
  3. Have the child use those inherited variables, and call event_inherited() in create.
  1. Duplicate the child. The duplicate will not highlight parent variables.

Which version of GameMaker are you reporting this issue for?

IDE v2024.1300.0.720 Runtime v2024.1300.0.733

Which operating system(s) are you seeing the problem on?

Windows 10.0.22631.0

f4296e69-beb0-4294-92c2-bb1c101e5b8b

@gm-bug-reporter gm-bug-reporter bot added ide-bug Bugs with the GameMaker IDE project This issue has a sample project attached labels Jan 22, 2025
@stuckie stuckie moved this from Triage to Todo in Team Workload Jan 23, 2025
@stuckie stuckie added this to the 2024.13 milestone Jan 23, 2025
@zreedy zreedy moved this from Todo to In Progress in Team Workload Jan 30, 2025
@zreedy
Copy link

zreedy commented Jan 30, 2025

Fixed. The Server did not read .yy files when the DidCreateFile event was dispatched.
This is not a straight forward fix because the Client may or may not have serialized the .yy file to disk by the time it dispatches the event. CoreResources dispatches events between a Duplicate, LoadProject, and CreateNewResource paths at different points in time with relation to disk serialization.

Please test this fix carefully by attempting to create many different resources in as many ways as possible. The fix for this made several assumptions about what ProjectInfo state indicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide-bug Bugs with the GameMaker IDE project This issue has a sample project attached
Projects
Status: In Progress
Development

No branches or pull requests

3 participants