Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning when adding/editing inline link #21959

Open
mhkuu opened this issue Jan 9, 2025 · 1 comment
Open

Deprecation warning when adding/editing inline link #21959

mhkuu opened this issue Jan 9, 2025 · 1 comment

Comments

@mhkuu
Copy link
Contributor

mhkuu commented Jan 9, 2025

Context: Why was this issue created?

When creating/editing an inline link in the block editor, with latest Gutenberg / Yoast SEO active, a deprecation warning is shown in the console:
wp.blockEditor.__experimentalLinkControl is deprecated since version 6.8. Please use wp.blockEditor.LinkControl instead.

What is the goal of this issue?

It would be nice if we don't show this console warning, and painful if we don't abide by the release of WordPress 6.8.

What needs to be done to achieve the goal?

In https://github.com/Yoast/wordpress-seo/blob/trunk/packages/js/src/inline-links/inline.js#L327 we reference this __experimentalLinkControl. We can probably get away with replacing that with const { LinkControl } = window.wp.blockEditor; and/or add something that still takes __experimentalLinkControl for older versions of Gutenberg.

Does the issue still need UX or research?

No.

If available: what are the tips for fixing the problem or possible solutions?

Obviously the Gutenberg repository 😅 The experimental functionality was stabilized in WordPress/gutenberg#56384, released as part of Gutenberg 19.9.

What is the expected result/behavior?

No console error while the functionality still works.

Should documentation be added or updated for this change? and if so, where?

Na.

@igorschoester
Copy link
Member

igorschoester commented Jan 9, 2025

Please be aware we will need to keep supporting __experimentalLinkControl until we no longer support WP 6.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants