Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A method where argument is plain_text url, if already exists, return the shorten one or create new one instead of throwing exceptions #19

Open
aleedksa opened this issue May 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aleedksa
Copy link

No description provided.

@yordadev yordadev added the bug Something isn't working label May 25, 2024
@yordadev
Copy link
Member

yordadev commented May 25, 2024

Hey @aleedksa thanks for submitting this issue.

I'm actively working on version 3 of this package. This update specifically addresses the issue of duplicate URLs, allowing them if the configuration is set accordingly. The package appends ?x_dup_link_id={uuid} to the URL before hashing it for the signature. An accessor on the ShortUrl model removes the x_dup_link_id={uuid} when using plain_text.

I'm aiming to submit a pull request next week for feedback before releasing version 3. It's a rather significant update.

I will leave this open until the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants