Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling needs to be cleaned up #3

Open
JasonTrue opened this issue Jun 29, 2022 · 0 comments
Open

Error handling needs to be cleaned up #3

JasonTrue opened this issue Jun 29, 2022 · 0 comments

Comments

@JasonTrue
Copy link
Member

In a haphazard manner to move from the ! version of ExAws.request/2, I return the error tuple inconsistently in a couple of spots in the sink.ex module.

This is just a reminder to make sure those actually conform to the shape specified in those callbacks as specified in Membrane, and add tests around that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JasonTrue