Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse Hessian boosting should overwrite oracle. #14

Closed
dkuzi opened this issue Apr 10, 2024 · 2 comments
Closed

Inverse Hessian boosting should overwrite oracle. #14

dkuzi opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dkuzi
Copy link
Collaborator

dkuzi commented Apr 10, 2024

If 'fit_oavi' is run with a variant of Frank-Wolfe and IHB is chosen to be 'weak' or 'full', the chosen oracle needs to be overwritten to be vanilla FW.

@dkuzi dkuzi self-assigned this Apr 10, 2024
@dkuzi
Copy link
Collaborator Author

dkuzi commented Apr 10, 2024

Also, add a message to inform the user of this

@dkuzi dkuzi added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Apr 10, 2024
@dkuzi
Copy link
Collaborator Author

dkuzi commented Jun 26, 2024

Added in 9745dfe

@dkuzi dkuzi closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant