Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit my cat! #38

Open
ZackeryRSmith opened this issue Jan 9, 2024 · 2 comments
Open

Fit my cat! #38

ZackeryRSmith opened this issue Jan 9, 2024 · 2 comments
Labels
enhancement New feature or request food Some food for the brain to munch on

Comments

@ZackeryRSmith
Copy link
Owner

Odd issue name I know, but it's quite indicative. Currently Bongocat-Plus spawns a window big enough to fit all sprites. The issue is: the resolution of an image can be bigger than the resolution of the screen. For some reason I've had trouble grappling this issue. Mainly because dilating the image with the window causes stretching. Locking to an aspect ratio isn't possible (in a cross platform way), and it has me confused.

I don't want developers to have to worry about their sprite size that much. The current idea is to not allow resizing the window but instead dilating the sprite(s) to match the window size. This creates less of a problem but it still doesn't make me satisfied. If anyone has ideas, feel free comment. I will continue to update with ideas on this issue or on the Discord server.

@ZackeryRSmith ZackeryRSmith added the enhancement New feature or request label Jan 9, 2024
@ZackeryRSmith ZackeryRSmith pinned this issue Jan 9, 2024
@ZackeryRSmith ZackeryRSmith added the question Further information is requested label Jan 13, 2024
@ZackeryRSmith ZackeryRSmith moved this to Todo in Refactor TODO Jan 13, 2024
@ZackeryRSmith ZackeryRSmith unpinned this issue Jan 16, 2024
@ZackeryRSmith
Copy link
Owner Author

Although important this has been unpinned for now, as I doubt the v1.0.0 of Bongocat will address this issue

@ZackeryRSmith ZackeryRSmith pinned this issue Feb 9, 2024
@ZackeryRSmith ZackeryRSmith added food Some food for the brain to munch on and removed question Further information is requested labels Feb 13, 2024
@ZackeryRSmith
Copy link
Owner Author

The solution for this is simple. Add functions for scaling sprites, this doesn't address window resizing in real time though. I think a solution like this would be fine though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request food Some food for the brain to munch on
Projects
Status: Todo
Development

No branches or pull requests

1 participant