Welcome to HomebridgeMagicHome-DynamicPlatform Discussions!

[Zacknetic]

👋 Welcome!

We’re using Discussions as a place to connect with other members of our community. We hope that you:

• Ask questions you’re wondering about.
• Share ideas.
• Engage with other community members.
• Welcome others and are open-minded. Remember that this is a community we
  build together 💪.

[EzzatQ]

Hey! Thanks for this awesome Plugin!

I have a dozen magic home controllers (RGB, GRB, GRBWW) but all my light strips are RGB.
Therefore for some of my light strips (the ones connected to a GRB or GRBWW controller) the red and green values are inverted. I've looked through the code to try and see if for these specific controllers (ex: GRB), I can set them up as RGB so that the colors won't be inverted.
Could you point me to where in the code I can do something like this?
(or even better, give us an option to set the controller/light the in the config)

Thanks in advance

[Zacknetic]

Ah, okay I understand the root of the problem now.

This can be solved two ways:

• Changing the config settings for simultaneous device saturation threshold. That way the white never turns on. (and RGB never turns off)
• Adding a feature which allows users to specify the controller type in the HomeKit name (my plugin can read names from HK. i.e. "Window Light $RGB" would set the device to RGB mode and erase $RGB from the name)

[EzzatQ]

Ok so I tried to change the code you suggested and the saturation threshold and it worked beautifully! Thank you very much!

I actually would be interested in working on a feature like this but I'm not really familiar with how to implement it with home bridge.
Would be nice to learn though (once I finish my exams) 😅

Again thank you very much

[Zacknetic]

Cool, happy to help.

In terms of that feature, once you have the time and motivation feel free to let me know here. You can join up as a contributor and the team and I would be happy to get you up to speed, answering any and all questions.

Enjoy.

-Z

[EzzatQ]

Hey @Zacknetic
So I ended up implementing the feature on a forked repository.
In the config.schema.json file, I added an option to add an array of uniqueId : controllerLogicType pairs which will override the automatically detected controllerLogicType.
Implemented the override code in platform.ts
You can check out my code here: EzzatQ/HomebridgeMagicHome-DynamicPlatform

Still didn't create a pull request because I am not sure how to test the code.
the source code on github is in Typescript but the code I found in home bridge has 3 copies of each file: .d.ts, .d.ts.map and .js
I assume these are the files that were converted from the .ts files (I don't know anything about Typescript but managed to still write the code)

Could you please help me with that so I can test the code?

also I'd like to become a contributor, I have some other feature ideas I'd like to implement (like managing the saturation thresholds per device and not globally)

EQ

[Zacknetic]

Thanks for putting the effort in! This type of implementation is not consistent with the vision of the plugin which is why I was hoping you'd let me know before you started hard work on it.

Join me on the MagicHome discord server and give me @Zacknetic a shoutout when you arrive. We can discuss this further.