fix: lint issue and unused var (#77)

* fix: lint issue and unused var

* fix: crypto rand package import

* fix: deepsource issue

Author: abskrj

controllers/upload.go

@@ -10,18 +10,17 @@ import (
 
 func GetPresignedURL(c *gin.Context) {
 	fileName := c.Query("fileName")
-	fileType := c.Query("fileType")
 	basePath := c.Query("basePath")
 	extension := filepath.Ext(fileName)
 
-	if fileName == "" || extension == "" || fileType == "" {
-		c.JSON(http.StatusBadRequest, gin.H{"error": "Missing required query parameter 'fileName' or 'fileType'"})
+	if fileName == "" || extension == "" {
+		c.JSON(http.StatusBadRequest, gin.H{"error": "Missing required query parameter 'fileName' or it has no extension"})
 		return
 	}
 
 	videoID := utils.VideoIDGen(extension)
 
-	url := utils.GetSignedURL(videoID, fileType, basePath)
+	url := utils.GetSignedURL(videoID, basePath)
 	if url == "" {
 		c.JSON(http.StatusInternalServerError, gin.H{"error": "Error generating presigned URL", "details": ""})
 		return

utils/helper.go

@@ -3,30 +3,26 @@ package utils
 import (
 	"bytes"
 	"crypto/rand"
-	"encoding/binary"
+	"encoding/base64"
 	"log"
-	math_rand "math/rand"
-	"strconv"
 )
 
 /*
 VideoIDGen returns an unique videoID and appends the fileExtension to it,
 it takes the fileExtensionas parameter
 */
 func VideoIDGen(fileExtension string) string {
-	var b [8]byte
-	if _, err := rand.Read(b[:]); err != nil {
-		return err.Error()
-	}
+	length := 8
+	randomBytes := make([]byte, length)
 
-	var i int64 = int64(binary.LittleEndian.Uint64(b[:]))
-	math_rand.Seed(i)
+	_, err := rand.Read(randomBytes)
+	if err != nil {
+		return ""
+	}
 
-	// Generate a 8 digit random number
-	randomNumber := math_rand.Intn(99999999-10000000) + 10000000
+	uid := base64.URLEncoding.EncodeToString(randomBytes)[:length]
 
-	// VideoID = (8-digit random number) + (file Name)
-	return strconv.Itoa(randomNumber) + fileExtension
+	return uid + fileExtension
 }
 
 // WrapStringInQuotes returns the string wrapped in quotes

utils/upload.go

@@ -245,10 +245,10 @@ func GetWhichCloudIsEnabled() (bool, bool, bool) {
 	return false, false, false
 }
 
-func GetSignedURL(videoId string, fileType string, basePath string) string {
+func GetSignedURL(videoId string, basePath string) string {
 	isAWS, isGCP, isAzure := GetWhichCloudIsEnabled()
 
-	filePath, err := GetCloudStoragePath(basePath, videoId, fileType)
+	filePath, err := GetCloudStoragePath(basePath, videoId)
 	LogErr(err)
 
 	if isAWS {
@@ -352,7 +352,7 @@ func generateAzureSignedURL(filePath string) string {
 	return sasURL
 }
 
-func GetCloudStoragePath(basePath, fileName string, _ string) (string, error) {
+func GetCloudStoragePath(basePath, fileName string) (string, error) {
 	url, err := url.JoinPath(basePath, fileName)
 	LogErr(err)