fix most warnings

Author: Zechiax

Asterion/AutocompleteHandlers/AnnouncementChannelPrecondition.cs

@@ -6,26 +6,26 @@ namespace Asterion.AutocompleteHandlers;
 
 public class AnnouncementChannelPrecondition : ParameterPreconditionAttribute
 {
-    public override async Task<PreconditionResult> CheckRequirementsAsync(IInteractionContext context,
+    public override Task<PreconditionResult> CheckRequirementsAsync(IInteractionContext context,
         IParameterInfo parameterInfo, object? value,
         IServiceProvider services)
     {
         if (value is null)
             // That's ok for us
-            return PreconditionResult.FromSuccess();
+            return Task.FromResult(PreconditionResult.FromSuccess());
 
         // We need to check if the channel is a text channel, because we can't send messages to voice channels
         if (value is not SocketTextChannel channel)
-            return PreconditionResult.FromError("Channel must be a text channel");
+            return Task.FromResult(PreconditionResult.FromError("Channel must be a text channel"));
 
         // We need to check if the bot has permissions to send messages to the channel
         if (channel.Guild.CurrentUser.GetPermissions(channel).SendMessages == false)
-            return PreconditionResult.FromError("Bot doesn't have permissions to send messages to the channel");
+            return Task.FromResult(PreconditionResult.FromError("Bot doesn't have permissions to send messages to the channel"));
 
         if (channel.Guild.CurrentUser.GetPermissions(channel).ViewChannel == false)
-            return PreconditionResult.FromError("Bot doesn't have permissions to view the channel");
+            return Task.FromResult(PreconditionResult.FromError("Bot doesn't have permissions to view the channel"));
 
         // All good
-        return PreconditionResult.FromSuccess();
+        return Task.FromResult(PreconditionResult.FromSuccess());
     }
 }

Asterion/Modules/ModrinthModule.cs

@@ -191,6 +191,15 @@ await ModifyOriginalResponseAsync(x =>
         // Get last version ID
         var lastVersion = versions.OrderByDescending(x => x.DatePublished).First().Id;
 
+        if (channel is null)
+        {
+            await ModifyOriginalResponseAsync(x =>
+            {
+                x.Content = "There was an error processing your request, check if the channel is correct";
+            });
+            return;
+        }
+
         await _dataService.AddModrinthProjectToGuildAsync(Context.Guild.Id, project.Id, lastVersion, channel.Id,
             project.Title);
 

Asterion/Services/Modrinth/ModrinthService.cs

@@ -319,13 +319,14 @@ public async Task<SearchResult<ProjectDto>> FindProject(string query)
                 projectFoundById = true;
             }
             // Not found status code is returned when requested project was not found
-            catch (ModrinthApiException e) when (e.StatusCode == HttpStatusCode.NotFound)
+            catch (ModrinthApiException e) when (e.Response.StatusCode == HttpStatusCode.NotFound)
             {
                 // Project not found by slug or id
                 _logger.LogDebug("Project query '{Query}' not found with ID or slug", query);
             }
             catch (ModrinthApiException e)
             {
+                _logger.LogDebug(e, "Error while searching for project '{Query}'", query);
                 return new SearchResult<ProjectDto>(new ProjectDto(), SearchStatus.ApiDown);
             }
             catch (Exception e)
@@ -401,7 +402,7 @@ public async Task<SearchResult<UserDto>> FindUser(string query)
             user = await Api.User.GetAsync(query);
             _logger.LogDebug("User query '{Query}' found", query);
         }
-        catch (ModrinthApiException e) when (e.StatusCode == HttpStatusCode.NotFound)
+        catch (ModrinthApiException e) when (e.Response.StatusCode == HttpStatusCode.NotFound)
         {
             // Project not found by slug or id
             _logger.LogDebug("User not found '{Query}'", query);

Asterion/Services/ProjectStatisticsManager.cs

@@ -28,7 +28,7 @@ public ProjectStatisticsManager(IServiceProvider services)
         DatabaseCleanupTimerElapsed(null, null);
     }
 
-    private async void DatabaseCleanupTimerElapsed(object? state, ElapsedEventArgs? elapsedEventArgs)
+    private void DatabaseCleanupTimerElapsed(object? state, ElapsedEventArgs? elapsedEventArgs)
     {
         const int removedEntries = 0;
         _logger.LogInformation("Running statistics database cleanup");