Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter subscription by loader type (Fabric, Paper, ...) #159

Closed
Zechiax opened this issue Sep 26, 2024 · 5 comments · Fixed by #174
Closed

Filter subscription by loader type (Fabric, Paper, ...) #159

Zechiax opened this issue Sep 26, 2024 · 5 comments · Fixed by #174

Comments

@Zechiax
Copy link
Owner

Zechiax commented Sep 26, 2024

No description provided.

@Zoriot
Copy link

Zoriot commented Nov 22, 2024

Do you know when you have time to implement that?
If it's not possible in the near future I would try it myself

@Zechiax
Copy link
Owner Author

Zechiax commented Nov 22, 2024

I have some spare time today, will see what I can do! 😁

I think the best solution would be to have a global settings and per project override. As Discord servers with paper used to host the MC server will probably not use Forge mods etc, so I'll try to make it like this.

@Zoriot
Copy link

Zoriot commented Nov 23, 2024

Sounds really great. 💯
Idk how complicated this global setting is, for now it would be okay too (for me) to only set if afterwards like it’s with the Release Type currently.
Then implement the global thing later on. Maybe also the same for release type - I think it would make sense there too

@Zechiax
Copy link
Owner Author

Zechiax commented Nov 23, 2024

Yeah, that sounds sensible for now, as the global settings would probably have to be for project types (mods, plugins, shaders, ..) as they have different loader types, so the current implementation will be per entry.
I'll make the global ones separate issues after this one is solved.

@Zechiax Zechiax linked a pull request Nov 23, 2024 that will close this issue
@Zechiax
Copy link
Owner Author

Zechiax commented Nov 23, 2024

The feature is live on the public instance. Let me know if you encounter any problems! 😊

It's configurable in the /entry <project_id> embed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants