Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Adaptive Options Should Be Respected on Error #277

Closed
cmeyertons opened this issue Aug 1, 2024 · 2 comments
Closed

[BUG] Adaptive Options Should Be Respected on Error #277

cmeyertons opened this issue Aug 1, 2024 · 2 comments
Assignees
@jodydonetti
Labels
enhancement New feature or request
Milestone
v1.3.0

Comments

@cmeyertons
Copy link
Contributor

Describe the bug

Currently, adaptive options are not respected on an exception.

This prevents application code from performing dynamic fail-safe logic based on the exception that was thrown (#275 )

To Reproduce

I have provided a PR with tests that were broken until illustrating the behavior (#276)

Expected behavior

Adaptive options are now respected on error, allowing for dynamic fail-safe enablement

Versions

I've encountered this issue on:

  • FusionCache version: 1.2
  • .NET version: net8.0
  • OS version: Windows 10
  • others: in-mem
@jodydonetti jodydonetti mentioned this issue Aug 1, 2024
Open
@jodydonetti
Copy link
Collaborator

jodydonetti commented Aug 1, 2024 •
edited
Loading

Hi @cmeyertons , thanks for pointing out this edge case.
I just reviewed + merged your PR, thanks a lot!

@jodydonetti jodydonetti self-assigned this Aug 1, 2024
@jodydonetti jodydonetti added this to the v1.3.0 milestone Aug 1, 2024
@jodydonetti jodydonetti added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 1, 2024
@jodydonetti jodydonetti pinned this issue Aug 4, 2024
@jodydonetti
Copy link
Collaborator

Hi all, v1.3.0 is out 🥳

@jodydonetti jodydonetti unpinned this issue Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodydonetti jodydonetti

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
2 participants
@jodydonetti @cmeyertons