From f6c1412677b4ae97838cf9b4f9ab486042b68e3e Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Thu, 21 Sep 2023 12:53:37 +0200 Subject: [PATCH 1/4] fix typo --- src/libServer/EthRpcMethods.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libServer/EthRpcMethods.cpp b/src/libServer/EthRpcMethods.cpp index 57b8c87243..39d399b006 100644 --- a/src/libServer/EthRpcMethods.cpp +++ b/src/libServer/EthRpcMethods.cpp @@ -1102,7 +1102,7 @@ std::string EthRpcMethods::GetEthCoinbase() { throw JsonRpcException(ServerBase::RPC_INVALID_REQUEST, "Unsupported method: eth_coinbase. Zilliqa mining " - "model is different from that of Etherium"); + "model is different from that of Ethereum"); } Json::Value EthRpcMethods::GetNetListening() { From 7a3f857dbad4f193adf9280145851ab3cf1c9580 Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Thu, 21 Sep 2023 12:55:08 +0200 Subject: [PATCH 2/4] fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e8baec09f1..f21195cb57 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,7 @@ The current live version on the Developer Testnet is Zilliqa [v9.2.5](https://gi ## Zilliqa Improvement Proposal (ZIP) -The Zilliqa Improvement Proposals (ZIPs) are the core protocol standards for the Zilliqa platform.To view or contribute to ZIP, please visit https://github.com/Zilliqa/zip +The Zilliqa Improvement Proposals (ZIPs) are the core protocol standards for the Zilliqa platform. To view or contribute to ZIP, please visit https://github.com/Zilliqa/zip ## Available Features From 473c029fbf7a92bd1f17b9802d7b50114e18c8cc Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Thu, 21 Sep 2023 12:57:26 +0200 Subject: [PATCH 3/4] fix typos --- docs/metrics | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/metrics b/docs/metrics index 85b4e17af6..e63045bc1f 100644 --- a/docs/metrics +++ b/docs/metrics @@ -6,7 +6,7 @@ Metrics are enabled in the cpp code by including the file The library support for metrics is provided in libUtils so you must link with this libs if you use metrics in your library module. -Metrics.h contains a number of useful Macros that simplfy the definition of metrics. +Metrics.h contains a number of useful Macros that simplify the definition of metrics. INCREMENT_METHOD_CALLS_COUNTER(COUNTER, FILTER_CLASS) INCREMENT_CALLS_COUNTER(COUNTER, FILTER_CLASS, ATTRIBUTE, VALUE) @@ -46,19 +46,19 @@ This file contains the filter definition which again is a macro. One may simply add a new definition into this macro and that's it all complexity taken care of. -This same pattern is used in the trace Filters and is implemented as a 64bit mask where each bit represents one of the classes defined here, this makes filtering extremely fast as its a simple test of the bit been set to enable or disable that class of filter at runtime. +This same pattern is used in the trace Filters and is implemented as a 64bit mask where each bit represents one of the classes defined here, this makes filtering extremely fast as it's a simple test of the bit been set to enable or disable that class of filter at runtime. That set of instructions covers simple incrementing counters. -You can also have non incrementing metrics, set the metric to any numeric value you please such as height or queue length. These metrics are implemented via a call back which is when the metric is captured. +You can also have non incrementing metrics, set the metric to any numeric value you please such as height or queue length. These metrics are implemented via a call back which is when the metric is captured. -These are slightly more complex in that you define the metric as an observable counter in you class or namespace. +These are slightly more complex in that you define the metric as an observable counter in your class or namespace. The observable. -In this example it was define in ScillaIPCServer.h +In this example it was defined in ScillaIPCServer.h zil::metrics::Observable m_bcInfoCount{ Metrics::GetInstance().CreateInt64Gauge( @@ -79,5 +79,5 @@ Periodically the open-telemetry services will invoke this method and move the va All the rest of the naming for the metric by the time it arrives at prometheus is handled by the implementation. -the metric will contains host/pod class type units and any further qualifying attributes and values these will be documented very soon -once the software is delivered. \ No newline at end of file +the metric will contain host/pod class type units and any further qualifying attributes and values these will be documented very soon +once the software is delivered. From 519201286a1080530c392681f85d5a9cbe070bdf Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Thu, 21 Sep 2023 12:58:37 +0200 Subject: [PATCH 4/4] fix typo --- docs/persistence.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/persistence.md b/docs/persistence.md index 8c129bf581..7f8169b0c0 100644 --- a/docs/persistence.md +++ b/docs/persistence.md @@ -50,7 +50,7 @@ These key value stores encode [Patricia Merkle Tries](https://ethereum.org/en/de | `contractStateIndex` | `h160` | [`ProtoStateIndex`] | Deprecated? | | `contractTrie` | `h256` | `[u8]` | See [tries](#tries) | | `dsBlocks` | `u64` | [`ProtoDsBlock`] | Maps DS block numbers to DS blocks. | -| `dsCommittee` | `u64` | `string; [PubKey; Peer]` | The value at key `0` will be a `u16` decimal string specifying the leader's ID. All remaining entries will have consequtive keys from `1` to `n`. There is an entry for each member of the DS commitee. Values are a concatenation of a [`Pubkey`] and a [`Peer`]. +| `dsCommittee` | `u64` | `string; [PubKey; Peer]` | The value at key `0` will be a `u16` decimal string specifying the leader's ID. All remaining entries will have consecutive keys from `1` to `n`. There is an entry for each member of the DS commitee. Values are a concatenation of a [`Pubkey`] and a [`Peer`]. | `extSeedPubKeys` | `u32` | [`PubKey`] | | `fallbackBlocks` | | | Deprecated? | | `metadata` | [`MetaType`] | Depends on the type | `MetaType::LATESTACTIVEDSBLOCKNUM` maps to a `u64`, the rest look to be deprecated.