Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use without material icon font #41

Open
ramijarrar opened this issue Jun 15, 2016 · 6 comments
Open

Use without material icon font #41

ramijarrar opened this issue Jun 15, 2016 · 6 comments

Comments

@ramijarrar
Copy link

ramijarrar commented Jun 15, 2016

Can you make the zodiase:material-design-icons-fonts dependency optional? We are using an SVG sprite to load our custom icon-set (as well as a small subset of the material icons) so the icon font from that package is unnecessary.

@ramijarrar ramijarrar changed the title Use without material icons Use without material icon font Jun 15, 2016
@Zodiase
Copy link
Owner

Zodiase commented Jun 16, 2016

This was part of the plan when I was trying to support configurable theme and SCSS but it got a bit too complicated for the time I had. I'll look into this some time soon.

@ramijarrar
Copy link
Author

ramijarrar commented Jun 16, 2016

Would it not just be a matter of removing this line/wrapping in a conditional based on settings? It seems like we already have good separation?

@Zodiase
Copy link
Owner

Zodiase commented Jun 16, 2016

That would be the solution except in package.js I can't reliably access the configs file thus there's nothing to be used as the condition. See the old code https://github.com/Zodiase/meteor-mdl/blob/1.0.6_3/package.js#L27 where I was trying to read the configs file from package.js. It worked when running locally but did not work at all once deployed.

@Zodiase
Copy link
Owner

Zodiase commented Jun 16, 2016

#26 is where I realized I can't access the settings file from within package.js.

@ramijarrar
Copy link
Author

ramijarrar commented Jun 16, 2016

Okay - makes sense. Have you considered removing the dependency altogether? I think the icons are sufficiently useful on their own, and having people install them separately isn't a huge burden (though obviously something that would be a breaking change).

@Zodiase
Copy link
Owner

Zodiase commented Jun 16, 2016

Breaking BC has been the major concern for not removing the dependency. Also I would like most users to not have to remember installing multiple packages.

BTW I may have realized a better solution than forking and editing just for this purpose. Say if you have a local package that matches zodiase:material-design-icons-fonts but actually does nothing, wouldn't that just effectively removes what you don't need? And you also get to keep this package updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants