-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use without material icon font #41
Comments
This was part of the plan when I was trying to support configurable theme and SCSS but it got a bit too complicated for the time I had. I'll look into this some time soon. |
Would it not just be a matter of removing this line/wrapping in a conditional based on settings? It seems like we already have good separation? |
That would be the solution except in |
#26 is where I realized I can't access the settings file from within |
Okay - makes sense. Have you considered removing the dependency altogether? I think the icons are sufficiently useful on their own, and having people install them separately isn't a huge burden (though obviously something that would be a breaking change). |
Breaking BC has been the major concern for not removing the dependency. Also I would like most users to not have to remember installing multiple packages. BTW I may have realized a better solution than forking and editing just for this purpose. Say if you have a local package that matches |
Can you make the
zodiase:material-design-icons-fonts
dependency optional? We are using an SVG sprite to load our custom icon-set (as well as a small subset of the material icons) so the icon font from that package is unnecessary.The text was updated successfully, but these errors were encountered: